Batchinsert and associative arrays about db

[SamMousa]

Associative arrays tend not to be ordered; I know they are but when using them you don't want to depend on the order of associative elements...

[rob006]

And how this is different from arrays indexed by integers? You still can have [2 => 2, 1 => 1, 3 => 3].

[rob006]

yiisoft/yii2#17066 (comment)

[Tigrov]

Point 2 was solved but point 1 still actual

[rob006]

The problem is not associative array, but invalid order of elements. If you pass associative array with correct order, everything will work fine:

$x->batchInsert('table1', ['a', 'b'], ['a' => 345, 'b' => 123]);

Throwing exception will break perfectly fine working code.

[SamMousa]

It's not, both of those are dictionaries; however php doesn't have lists so they are also dictionaries... These are conceptually different. My point not related to the order of elements BTW, in the correct order things like typecasting still don't work. Check the source if you don't believe me...

[paweljankowiak06]

I had similar issue and as simple solution I used keys from array as argument.

$array = ['b' => 123, 'a' => 345];
$x->batchInsert('table1', array_keys(reset($array)), $array);

This does not cover different keys order in every array but when every array has same keys order this should work. Also when you change/add/delete one of key this should still work.

[samdark]

Currently associative arrays have no meaning in batch insert. Keys are ignored. What's the use case for naming columns explicitly in each element of a huge data array?

[SamMousa]

I don't have one, I just happened to get the data with keys. Then I found out the hard way that typecasting was broken because of it.

[samdark]

Well, then we can conclude that the format supplied wasn't supported and it was said nowhere in the docs that it would work. I see no reason to support such format in the future.

[SamMousa]

@samdark You misunderstand me; I'm not proposing adding support, i'm proposing to make failure more obvious:

My proposal is to actively check each key in the row data and throw a hard exception if it's not numerical.

Since we're already iterating it's a cheap thing to do and will make non-apparent failures more obvious.

[samdark]

Ah, good to go then.