Database connection charset about db

@samdark commented on Jul 19, 2018, 3:39 AM UTC:

It's not connected to schema. Could be moved to specific connection classes though.

@SamMousa commented on Jul 19, 2018, 5:30 AM UTC:

It is DBMS specific though; different DBMS can have different way of setting the charset

@SamMousa commented on Jul 25, 2018, 11:45 AM UTC:

samdark Currently the schema classes contain all DBMS specific code, does it not make more sense to have it in there than in the current Connection class?
The downside of having multiple connection classes is that the current approach of just changing the DSN no longer works.
Specifically the DSN, username and password are often provided via external configuration, while the rest of the connection configuration is done in the code.

@SamMousa commented on Jul 27, 2018, 8:25 AM UTC:

I just found this: http://php.net/manual/en/ref.pdo-mysql.connection.php.
Since php 5.3.6 the normal charset as part of the DSN is supported in PDO_MYSQL, making the execution of SET NAMES redundant (for mysql at least).