Comments (8)
Great @Yingjie4Science! Thanks. I noticed the other reviewer's great suggestions and extending the test coverage was a great improvement.
from sdgdetector.
Thank you, @caleblucas , for taking your time review our paper. This is a great suggestion, which can help make our major contribution stand out more. I have revised the text, and you should be able to see the new added text from this link 3cbb5af
from sdgdetector.
Great, thanks @Yingjie4Science! Is there a way to reproduce the performance metrics provided in the paper/repo (e.g. pg 3 here https://drive.google.com/file/d/1EHUV6Jc3N4A-IshKU4dbxtIqlfj50mzi/view)? Code to reproduce/verify the metrics needs to be in the repo I believe.
from sdgdetector.
Also, sdg_icon()
is handy! Nice idea.
from sdgdetector.
@Yingjie4Science can you please add a citation to text2sdg
in the references section of the paper?
from sdgdetector.
Hi @caleblucas, thanks again for the suggestions!
- We have added the code and data for reproducing the performance metrics, see f3148f9
- I am glad you like this small function! I find it very useful and handy too!
- We cited
text2sdg
in other sections and I agree we need to add a citation totext2sdg
in the paragraph where we discussed the key differences betweenSDGdetector
andtext2sdg
. See our revision here 1932a53
from sdgdetector.
@Yingjie4Science fantastic! thank you. can you please link the performance metric files in the readme (probably next to where the supplementary document is linked now?) and note somewhere in the paper that the data/code to replicate those results are available in the repo?
from sdgdetector.
@caleblucas Yes! We have added related text in the repo's readme (b87c4e5) and in the paper (see 56cf11f)
We have also added more tests per another reviewer's suggestions, and the current test coverage is 93.45%. See bfed791
from sdgdetector.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdgdetector.