JOSS Review about sdgdetector

[caleblucas]

Great @Yingjie4Science! Thanks. I noticed the other reviewer's great suggestions and extending the test coverage was a great improvement.

[Yingjie4Science]

Thank you, @caleblucas , for taking your time review our paper. This is a great suggestion, which can help make our major contribution stand out more. I have revised the text, and you should be able to see the new added text from this link 3cbb5af

[caleblucas]

Great, thanks @Yingjie4Science! Is there a way to reproduce the performance metrics provided in the paper/repo (e.g. pg 3 here https://drive.google.com/file/d/1EHUV6Jc3N4A-IshKU4dbxtIqlfj50mzi/view)? Code to reproduce/verify the metrics needs to be in the repo I believe.

[caleblucas]

Also, sdg_icon() is handy! Nice idea.

[caleblucas]

@Yingjie4Science can you please add a citation to text2sdg in the references section of the paper?

[Yingjie4Science]

Hi @caleblucas, thanks again for the suggestions!

• We have added the code and data for reproducing the performance metrics, see f3148f9
• I am glad you like this small function! I find it very useful and handy too!
• We cited text2sdg in other sections and I agree we need to add a citation to text2sdg in the paragraph where we discussed the key differences between SDGdetector and text2sdg. See our revision here 1932a53

[caleblucas]

@Yingjie4Science fantastic! thank you. can you please link the performance metric files in the readme (probably next to where the supplementary document is linked now?) and note somewhere in the paper that the data/code to replicate those results are available in the repo?

[Yingjie4Science]

@caleblucas Yes! We have added related text in the repo's readme (b87c4e5) and in the paper (see 56cf11f)

We have also added more tests per another reviewer's suggestions, and the current test coverage is 93.45%. See bfed791