GithubHelp home page GithubHelp logo

Comments (10)

jrfnl avatar jrfnl commented on August 15, 2024

Hi Jeremy,

FYI: I just had a quick look at this - thinking it could be a quick fix to add -, but it's not actually that easy to implement - if at all possible -.

Notes for developers (in case it would be decided to implement this):

The main feed and the comments feed are echo'd out in one go by the feed_links() function in the wp-includes/general_template.php file. This function does not offer a way to filter the output, so it's either have both links or none at all (by removing the function from the wp_head actions queue - which is what the plugin currently does if the option to do so is turned on -).

The only way I can currently think of to do this, would be to copy the WP-core function into the plugin and add a conditional display option for the comments link there, remove the WP feed_links action and add an action to the copied function.

This however would create kind of a maintenance nightmare - quite apart from it being bad practice - as you'd have to keep an eye on any changes made to the WP-core function and be sure to emulate these into the function copied into the plugin.

A better route might be to submit a patch to WP core which adds an output filter to the feed_links() function. However getting these kind of patches accepted & merged is often a slow process, so no telling when the filter would be available.

Ok, that's my two pennies... ;-)

Smile,
Juliette

from wordpress-seo.

GermanKiwi avatar GermanKiwi commented on August 15, 2024

From what I've since read and learned, it's not possible to disable the comments feed without also disabling the main feed as well. It's either both or none.

So I've solved this for myself by disabling both feeds (using the appropriate 'remove_action' in my functions.php), and then manually adding back just the main feed via another function in my functions.php file. This does the trick for me and I think it's the only solution currently available.

I'll close this ticket as this request is obviously beyond the scope of this plugin.

from wordpress-seo.

jdevalk avatar jdevalk commented on August 15, 2024

Well, it's not possible right now, but I do want to make it possible, so I'm reopening.

from wordpress-seo.

GermanKiwi avatar GermanKiwi commented on August 15, 2024

Well, okay - thanks! :)

from wordpress-seo.

fastmover avatar fastmover commented on August 15, 2024

This would be a great feature.

from wordpress-seo.

jdevalk avatar jdevalk commented on August 15, 2024

Just submitted a patch to core to make this possible. Find it here: https://core.trac.wordpress.org/ticket/23692

from wordpress-seo.

GermanKiwi avatar GermanKiwi commented on August 15, 2024

Nice! Thanks for doing so!

from wordpress-seo.

tacoverdo avatar tacoverdo commented on August 15, 2024

Current status of core-patch that would make this possible:
has-patch

from wordpress-seo.

Rarst avatar Rarst commented on August 15, 2024

Core patch merged for 4.4. I wonder though how to implement this specific to a version of core. Do we just silently hide setting when running on earlier versions?

from wordpress-seo.

Rarst avatar Rarst commented on August 15, 2024

The removal of header links feature has been dropped from the plugin.

See #3599

from wordpress-seo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.