GithubHelp home page GithubHelp logo

Size of editor about markx HOT 6 CLOSED

yoavram avatar yoavram commented on August 28, 2024
Size of editor

from markx.

Comments (6)

Carreau avatar Carreau commented on August 28, 2024

May I suggest CodeMirror which support Markdown highlighting.
We use it in IPython, and it has an autogrow capability.

from markx.

yoavram avatar yoavram commented on August 28, 2024

I'll have a look, thanks!

from markx.

yoavram avatar yoavram commented on August 28, 2024

I changed the editor from PageDown to CodeMirror, see ab20bc5.
Waiting for feeback if this should be merged to the master branch.
You can also add arbitrary pre and post conversion hooks by writing something like in the js console:

addPreCoversionHook(converter, function(text) { return text.replace("GitHub", "[GitHub](http://github.com)") })

which will convert appearances of GitHub in the markdown to markdown links to GitHub site.

/cc @Carreau @karthikram @lsaravia

from markx.

lsaravia avatar lsaravia commented on August 28, 2024

I like the space between lines that has PageDown, but there are other features of CodeMirror that are interesting, line numbers and highlighting. CodeMirror has some problem with math that makes the text italicized between $. And the math is not rendered in the preview pane.

from markx.

yoavram avatar yoavram commented on August 28, 2024
  1. The space between lines can be modified in static/css/codemirror.css by adding a line-height: 200%; or something similar (you can specify percent or em units, I think) in the .CodeMirror-lines class. Let me know what you think is a good default and I'll set it (or you could create a pull-request).
  2. The CodeMirror highlighting is not perfect, I'm not sure why it highlights some of the text, but I guess that could be fixed by either digging into it or by using a less intrusive theme (you can see other themes here available here and if there is one you think will be better let me know, I chose the elegant theme because I thought it was neat).
  3. The math rendering was a bug - i fixed it in cca50e0.

from markx.

yoavram avatar yoavram commented on August 28, 2024

Changed line spacing to 150% and merged codemirror branch to master.
Closing this issue.

from markx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.