GithubHelp home page GithubHelp logo

Comments (23)

rishabh3 avatar rishabh3 commented on May 20, 2024

@manparvesh I am new to opensource i would like to work on it please help me!

from yoda.

manparvesh avatar manparvesh commented on May 20, 2024

Hi @rishabh3,
Thanks for your interest in the project. You can take a look at the Contributing guidelines. In case of any doubts, you can ask me here.

from yoda.

rishabh3 avatar rishabh3 commented on May 20, 2024

from yoda.

manparvesh avatar manparvesh commented on May 20, 2024

How are you running a command? you need to prepend dude to your commands

from yoda.

rishabh3 avatar rishabh3 commented on May 20, 2024

from yoda.

manparvesh avatar manparvesh commented on May 20, 2024

Can you tell me your OS and the complete procedure you followed for this? I am not able to see anything like this in my system.

from yoda.

rishabh3 avatar rishabh3 commented on May 20, 2024

from yoda.

manparvesh avatar manparvesh commented on May 20, 2024

Oh I am using Python 2.7. Maybe that is the problem?
Or you can try installing python-dev, maybe that can work

from yoda.

manparvesh avatar manparvesh commented on May 20, 2024

And regarding the vocabulary file not found, it is a bug. Referenced in #7

from yoda.

rishabh3 avatar rishabh3 commented on May 20, 2024

@manparvesh so now its working python 2.7 thanks for the help!

from yoda.

rishabh3 avatar rishabh3 commented on May 20, 2024

from yoda.

manparvesh avatar manparvesh commented on May 20, 2024

Yes, you are thinking correct! You are welcome to create a PR for this.
However for the index out of bounds error, I think you should create a new Issue and we should fix it there.

from yoda.

rishabh3 avatar rishabh3 commented on May 20, 2024

No i have already fixed it so if any one will give a wrong index then it continuously ask for a valid input

from yoda.

manparvesh avatar manparvesh commented on May 20, 2024

I understand. I am asking you to create an Issue describing the bug and then a Pull request fixing that issue.

from yoda.

rishabh3 avatar rishabh3 commented on May 20, 2024

@manparvesh can you help me what to do now? After working on this issue what should i do? I didnot understand what you meant by pull request.

from yoda.

rishabh3 avatar rishabh3 commented on May 20, 2024

like now i have completed it and want to put my code what should i do? please tell me the steps
First time so i have no idea about this

from yoda.

manparvesh avatar manparvesh commented on May 20, 2024

@rishabh3 you have made the changes in your local machine. But you need to make the changes in the github repository as well.

  • For that, you should first fork the project (third button at the top of every repository). When you do that, a copy of this repository will be made in your account.
  • Then you should clone it and make the changes in the code.
  • Add and commit the changes, and then push to your repository (remember that you cannot push to this repository)
  • When you push the code to your repo, a button will be displayed showing that you can create a pull request.
  • Then you need to provide a description of what you have fixed.
  • Then I will review the changes in the code..
  • When I accept the pull request, your code will be merged in the main repo.

from yoda.

rishabh3 avatar rishabh3 commented on May 20, 2024

from yoda.

rishabh3 avatar rishabh3 commented on May 20, 2024

@manparvesh I have made the corresponding changes and committed it u can take a look

from yoda.

manparvesh avatar manparvesh commented on May 20, 2024

@rishabh3 there are bugs after merging your code. Please consider all possibilities next time

  • you have written date = entry['date'] 2 times, but there is no 'date' key
  • you are taking all the files when analyzing and it includes notes files as well, hence there are errors in running analyze command
  • You should write good commit messages.

from yoda.

rishabh3 avatar rishabh3 commented on May 20, 2024

@manparvesh i have made the changes mentioned by you

from yoda.

rishabh3 avatar rishabh3 commented on May 20, 2024

from yoda.

manparvesh avatar manparvesh commented on May 20, 2024

@rishabh3 The changes made in your repo can no longer be added to the PR, since the PR is already merged. I have fixed the bugs in your code, but please take care of these things next time.
Since your repo is not synced with the main repo, you can do so by taking a look here

from yoda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.