Reusing serializer instance? about panko_serializer

[mikebaldry]

I'll PR soon. Thanks

[yosiat]

Hi @mikebaldry

You can't re-use serializer since serializer have state (the object you are serializing).

[mikebaldry]

I see. It seems a little wasteful that I need a new serializer for every object I serialize, even if they are instances of the same class. Could the serializer work this way and cache information about the class that is being serialized, to allow it to run more efficiently?

Can I suggest throwing an error if you attempt to use a serializer for a second time? It behaves oddly when serializing another object, but doesn't fail, which I think it should to avoid confusion or bugs.

Thanks

[yosiat]

@mikebaldry create new serializer is really really cheap, all the data is calculated at the class level of the serializer - if you can show me a benchmark/something that proves it to be time taking I can think about changing this.

And I am ok with code change for throwing an error when reusing a serializer - let me know if you want to make a PR or shall I.