Comments (6)
We can add new show-confirm-button and show-cancel-button props and keep confirm-button-text as string type
from vant.
Yes, this is also a feasible solution, and I remain open to it.
from vant.
Current solution is to override confirm
slot but it is requires more code.
from vant.
vant/packages/vant/src/picker/PickerToolbar.tsx
Lines 55 to 63 in dbf8027
from vant.
Hello @mahnunchik. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to main
branch, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!
你好 @mahnunchik,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到 main
分支,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待你的贡献。
from vant.
@chenjiahan Yes, it is one of possible solutions.
But my point of view, that show-*
props for all *-text
texts may encrise amount of props almost twice.
Another option is to fix handling empty strings here
to be able to render empty sting by:confirm-button-text=""
as expected.
I mean something like the following:
const text = props.confirmButtonText !== undefined ? props.confirmButtonText : t('confirm');
from vant.
Related Issues (20)
- [Bug Report] van-watermark 组件水印全页显示 HOT 5
- Vant 4.8.11 Highlight 高亮文本 当没有需要高亮的文本时源文本不显示
- [Bug Report] 按需引入vant,showImagePreview样式丢失 HOT 2
- 关于 uniapp HOT 1
- [Bug Report] cascader 默认赋值问题
- 国内站点地址挂了 HOT 9
- [Bug Report]SwipeCell 滑动单元格点击事件错误捕获 HOT 3
- [Bug Report] 关于步进器stepper建议修复下autocomplete问题,应该是默认off或者做成可以配置的 HOT 1
- [Bug Report] useCountDown倒计时总时长被本地时间影响 HOT 1
- [Bug Report] IOS17.4.1版本使用upload组件进行拍照上传的时候会造成页面白屏崩溃 HOT 2
- vant/cli css 打包bug Selector "[data-v-5c89f644]" can't have a suffix
- Gitee 文档站下线通知 & 解决方法 HOT 3
- [Bug Report] IOS 17.4.1 van-uploader 无法选择本地图片
- css样式误差, 感觉像是样式丢失了一样。 HOT 3
- [Bug Report] Area组件中columns-placeholder属性在选择省份和城市数据后出现展示问题 HOT 2
- van-field在自适应高度时,同时添加max-height属性,在超出限高再输入中文时,内容总是滚动到顶部。 HOT 2
- vant-swiper使用动态分页数据,在部分安卓机型,最后一页滑动,会出现白屏
- [Bug Report] vant组件使用插槽以后内部的组件属性watch会有异常问题
- [Bug Report] Tab内嵌套滚动Tab,滚动Tab点击下标响应不正确
- [Bug Report] DropdownMenu 下拉菜单给options属性赋值时采用调用方法的形式时,控制台报警告Uncaught (in promise) Maximum recursive updates exceeded in component <van-dropdown-menu>. This means you have a reactive effect that is mutating its own dependencies and thus recursively triggering itself. Possible sources include component template, render function, updated hook or watcher source function.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vant.