yukiawano / sscpmodule Goto Github PK

Add javascript based condition.
Developer can use javascript functions for setting conditions.

Add on-site browsing activity condition.

Add in-option, by using which user can specify the location with the center point and radius.

Reference : https://groups.google.com/d/msg/silverstripe-dev/9AWkjzOICuw/GWaCbd3aoOgJ

Nearest option has a bug. The reason is that we calls geo-coding apis many times. I'll remove the address specification from nearest option.

Creating blocks many times is really boring. We enable to assign multiple Audience Types to a Block.

Add manual flag condition.

In this condition, user can set condition by themselves.
User can create a link for set a flag and redirect the visitor. Example is the below.

/mcondition?flag=downloaded&redirect=http://domain/download_url

When a visitor has accessed to the url, the user is redirected and marked as "download".

We can create a audience type who has downloaded the file from the url as,

DownloadedUser:
  Manual: downloaded

Add Notice, link to installation instruction, and License to the front page.

What do you think about putting the Notice and Installation instruction on the front page (https://github.com/yukiawano/sscpmodule/blob/master/README.md)? At least the Notice shouldn't be burried inside the docs, but should be clearly visible on the front page.

Please add a License to https://github.com/yukiawano/sscpmodule/blob/master/README.md - BSD I assume?

This issue is related to #2

Add a default location option to this module. Default location is used in the first time access. We get the location of the user in the lazy way. Because we need web api calls to get a location of a user and we need to render the page fast.

Make BlockHolder Extensible. This is a step for making customized BlockHolder, such as Slideshow BlockHolder.

Currently only html snippet is available. Make the snippet extensible, and add image snippet as the first extension.

Extension of Snippet

Every snippet in this module has extended from SnippetBase class.

Image Snippet

This snippet is intended for showing an image banner.
Image Snippet has image field and url field.
If the url field empty, the image is unlinked. When you type an url, the image has a link.

As far as I could see thirdparty/ip2locationlite.class.php doesn't provide any license details (already the download package doesn't have it).

Could you please add a comment to the file giving the source URL (so we know where to check for API changes) plus state that there is no license specified for the code? We need to be very careful with attributing third-party code.

Thanks!

In the AudienceTypes section, please describe what this is actually doing. People might guess what it does, but we should make that clear beyond any doubt ;-).

Add clear description about AudienceTypes to getting-started.md.
Using images would be good for good explanation.

This issue is related to #2 .

Add radius option to location condition.

Currently we are developing block based personalization. In the personalization, each user sees different content in each block. In other words, the area which is personalized is just in the block.

In query based personalization, we personalize content by changing query.

For example, if there is a parent page A at top-level, and it has 3 children, X, Y, Z.
When AudienceTypeM accesses the site, menu(2) for page A returns X, Y, while it returns Y, Z for AudienceTypeN.

To get more about query based personalization, see this discussion.

Find a best way to manage sub-modules. (If it is available, use Andrew's GSoC Project.)

This issue is related to b762a63#commitcomment-1437829 .

Refactor existing codes

Logics of adding SSCP_Block is currently in BlockHolderMain controller. This is not in the right place. These codes should be refactored.

MatchingType in audiencetype.yml is not used now. It may be useful that it should be move into BlockHolder.