GithubHelp home page GithubHelp logo

Comments (8)

Apollon77 avatar Apollon77 commented on August 23, 2024 1

Happy review :-)
#23

from serialport-gsm.

Apollon77 avatar Apollon77 commented on August 23, 2024

Me personally terminate lines with ; and I mainly use === wherever possible.

from serialport-gsm.

karianpour avatar karianpour commented on August 23, 2024

As the project is under production , changing == to === might cause break. So I suggest to use === when we add a new functionality or when we change and test a function.
About the ;, it is programmer preference, as @zabsalahid started the project without it, I respected the convention.

from serialport-gsm.

zabsalahid avatar zabsalahid commented on August 23, 2024

Hello @karianpour and @Apollon77 !

Yep, I started the project without it. I find it more clean and neat. Since javascript automatically adds semicolon if it needs to. Thanks.

from serialport-gsm.

Apollon77 avatar Apollon77 commented on August 23, 2024

Ok to both from my point of view.

In my first PR I have unified the used quotes BTW

from serialport-gsm.

Apollon77 avatar Apollon77 commented on August 23, 2024

PS: I would change "===" whereever possible without breaking thing

from serialport-gsm.

zabsalahid avatar zabsalahid commented on August 23, 2024

@Apollon77 reviewing.

from serialport-gsm.

Apollon77 avatar Apollon77 commented on August 23, 2024

From my point of view we could also close here ... "===" was adopten where easiely possible and the seicolons are "defined code style" same as the "two space indent" :-)

from serialport-gsm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.