GithubHelp home page GithubHelp logo

RTL support about just-read HOT 5 CLOSED

zachsaucier avatar zachsaucier commented on June 6, 2024
RTL support

from just-read.

Comments (5)

ZachSaucier avatar ZachSaucier commented on June 6, 2024 1

I uploaded a fix in version 1.0.17 which makes the main content support the direction specified in the original page's body, which seems to be done in every RTL page I've checked so far, though it might not always be the case.

I didn't apply RTL to the meta information (date, author, etc) because that'd add a little complexity to the project. Let me know if you think it's enough as is or is jarring so much that I should write a more complex fix.

from just-read.

ZachSaucier avatar ZachSaucier commented on June 6, 2024 1

I went ahead and moved the title, date, and author into something that looks better in RTL as well. So now it should look better and the edit metadata edit functionality should work better.

from just-read.

ZachSaucier avatar ZachSaucier commented on June 6, 2024

Hello maxyor,

Could you please provide a link to an example where this behavior doesn't work as you expect it to?

Though I do have test cases, such as this website.

Since the direction: rtl; is applied on the body, JR is stripping it. I can fix that.

from just-read.

maxyor6040 avatar maxyor6040 commented on June 6, 2024

Wow that was fast. Bug fixed for me. Thanks.

from just-read.

ZachSaucier avatar ZachSaucier commented on June 6, 2024

This has since been updated (due to #116) to check the first child of the selected content for any RTL characters. If one is found, RTL for JR is also set.

from just-read.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.