Formatter doesn't respect the <pre> tag about just-read

[ivannieto]

I always do it. The example provided is not written by me, it was just found on the net. 😄 Cool. I'll be waiting for updates. Thanks, and thanks for the great job Zach!

[ZachSaucier]

Just a note: if there's a section of code that is only inside of a <pre> tag that you really need to be formatted, you can use your dev tools to add the <code> tag surrounding that content before running Just Read. Since it grabs the page at the time when it's ran, Just Read will include the <code> in its version.

[ZachSaucier]

Can you please provide an example page where this error occurs?

Are you talking about just plain <code> tags without a <pre> tag surrounding it?

[ivannieto]

Hmmm I see now, the article has no code tag embedded into the pre content so it should had bypassed it. BTW, text inside a pre tag should be formatted as it is stated. It's not relative to the code tag (if we want to avoid this kind of problems). You could extract the code from this article: http://elmanantialdebits.blogspot.com.es/2013/08/que-es-eso-de-la-programacion-asincrona.html

[ZachSaucier]

Thanks for bringing this up. This behavior was purposely implemented. <pre> tags with no <code> inside of them are converted to <p> tags in Just Read's format.

This is done because some sites that I've come across (unfortunately I didn't save the link(s)) put regular types of text content inside of the <pre> tag. Since Just Read is meant to take all formatting away from article type of content, I convert it to a <p> tag so that the browser's styling is removed.

With that being said, if you come across several sites where this is an issue, where the <pre> formatting is actually needed, I'm open to changing the way the <pre>s are handled.

---

With that being said, there's a small error in how the line breaks of <pre>s are handled on that page - they should have the same number of lines as the <pre> tags, just in <p>s instead. I'll look into what's causing that issue.

[ZachSaucier]

Update: The error in handling line breaks inside of <pre>s should be fixed as of b2c7227 / version 1.0.2. Let me know if that is satisfactory for your use case.

[ivannieto]

Line breaks work well now for the example provided, but it keeps bypassing indenting.

With Just Read ON it shows this now, as you can see:

leer_teclado_asincrono(t => {
leer_fichero_asincrono(f => {
leer_datos_asincrono(d => {
imprime(t,f,d)
})
})
})

[ZachSaucier]

For now I will keep the functionality as it was originally designed for the reasons stated above.

If you're writing pages that use code, make sure to use the <code> element!

[dflock]

This breaks code blocks in any site that uses MediaWiki - like Wikipedia, etc... See this page for an example: https://en.wikipedia.org/wiki/Web_storage#sessionStorage

The code blocks on Wikipedia are just <pre> tags, not <pre><code>, so they get borked.

Would be nice if there was a setting for this - "Keep <pre> tags" or something.

[ZachSaucier]

I added the ability for users to choose whether or not to reformat <pre> tags in "Additional options" on the Options page as of version 1.0.14.

Thanks for the comment!

[dflock]

Great, thanks!

…

On Wed, 14 Dec 2016, 19:28 Zach Saucier, ***@***.***> wrote: I added the ability for users to choose whether or not to reformat <pre> tags in "Additional options" on the Options page as of version 1.0.14. Thanks for the comment! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#9 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAC6jBuIpK1OpeZxSQ0oET0Iz_sRVsD-ks5rILP1gaJpZM4J4j37> .