GithubHelp home page GithubHelp logo

Comments (9)

zack-bitcoin avatar zack-bitcoin commented on June 24, 2024

If your oracle ID is base64 encoded, then the API cannot accept it.
This is not a mistake.

from amoveo.

Sykh avatar Sykh commented on June 24, 2024

To be fair the documentation is pretty useless then since all oracle ids you can see in the lightnode or the explorers are base64 encoded, i dont think there is any place you actually get a decoded id except the node on oracle creation which also trims that output since its too long.

So the documentation should be updated to a useable command or cover both cases or better yet, update the functions so they base64:decode themself like the curl api calls do...

from amoveo.

zack-bitcoin avatar zack-bitcoin commented on June 24, 2024

There are hundreds of places in the code where I would have to check the input and possibly decode base64.
I think the solution is to add oracle_close capabilities to the light node.

from amoveo.

zack-bitcoin avatar zack-bitcoin commented on June 24, 2024

And we need to test everything for the full range of inputs, so this would involve doubling the number of tests.

duck typing is a lot of work, we should only use it if we need it.

from amoveo.

zack-bitcoin avatar zack-bitcoin commented on June 24, 2024

The full node doesn't accept base64 encoded pubkeys to send veo either.
It is consistent in the format that it expects.

from amoveo.

Sykh avatar Sykh commented on June 24, 2024

This is logical for you since you know the source and that is what you are working with but users reading the documentation wont get far with it, like ben said, you copy paste the command and yes, it doesn't work so the documentation is wrong there since it's a user documentation, not the api.

I agree on the lightnode part, the fullnode should be needed and used as little as possible.

from amoveo.

zack-bitcoin avatar zack-bitcoin commented on June 24, 2024

If Ben regularly used the full node, this wouldn't matter.
I think he set up a full node just to close an oracle and nothing else.
He is a light node user, and needs to be able to do this from the light node.

from amoveo.

jadefalke avatar jadefalke commented on June 24, 2024

I think the Documentation should empower everyone who wants it to use the Full node. Otherwise the Documentation is useless.

from amoveo.

zack-bitcoin avatar zack-bitcoin commented on June 24, 2024

there is no more "base64" on that page, so I guess this was solved.

from amoveo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.