Comments (9)
If your oracle ID is base64 encoded, then the API cannot accept it.
This is not a mistake.
from amoveo.
To be fair the documentation is pretty useless then since all oracle ids you can see in the lightnode or the explorers are base64 encoded, i dont think there is any place you actually get a decoded id except the node on oracle creation which also trims that output since its too long.
So the documentation should be updated to a useable command or cover both cases or better yet, update the functions so they base64:decode themself like the curl api calls do...
from amoveo.
There are hundreds of places in the code where I would have to check the input and possibly decode base64.
I think the solution is to add oracle_close capabilities to the light node.
from amoveo.
And we need to test everything for the full range of inputs, so this would involve doubling the number of tests.
duck typing is a lot of work, we should only use it if we need it.
from amoveo.
The full node doesn't accept base64 encoded pubkeys to send veo either.
It is consistent in the format that it expects.
from amoveo.
This is logical for you since you know the source and that is what you are working with but users reading the documentation wont get far with it, like ben said, you copy paste the command and yes, it doesn't work so the documentation is wrong there since it's a user documentation, not the api.
I agree on the lightnode part, the fullnode should be needed and used as little as possible.
from amoveo.
If Ben regularly used the full node, this wouldn't matter.
I think he set up a full node just to close an oracle and nothing else.
He is a light node user, and needs to be able to do this from the light node.
from amoveo.
I think the Documentation should empower everyone who wants it to use the Full node. Otherwise the Documentation is useless.
from amoveo.
there is no more "base64" on that page, so I guess this was solved.
from amoveo.
Related Issues (20)
- move a channel bet to a direct path. HOT 1
- Sync mode that downloads blocks without merkel proofs, and generates the merkel proofs locally. HOT 2
- syncing optimization
- optimizing futarchy for least volatility HOT 4
- probabilistic payment HOT 20
- multisig accounts
- purely functional on-chain smart contracts. HOT 4
- more efficient merkel tree database
- more efficient merkel tree database HOT 2
- hard update 17 changes HOT 1
- accumulator database instead of merkel HOT 1
- checkpointing, and syncing blocks in reverse time order HOT 1
- Protocol 'inet_tcp': register/listen error HOT 5
- soft update to enable betting on oracles that do not yet exist. HOT 2
- Cheaper oracles HOT 1
- hard update 25
- Issues with proof that PoS consensus doesn't work HOT 3
- require miners to run full nodes
- partially matching channel offers
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amoveo.