(Bug report) TypeError: Cannot read properties of undefined (reading 'attachmentId') when copy/pasting images about trilium

[zadam]

@ghgr hello, thank you for further testing. The previous fix was unescaping the URL in an incorrect place which then made it impossible to find the correct URL in HTML to replace. Bill Gates is now getting properly replaced.

[zadam]

Hello, thank you for the detailed report, should be fixed in the next patch release.

[ghgr]

Thank you @zadam !

Just a quick heads up, since you're now escaping the url, the function replaceUrl in notes.js:514 is not matching the original url, and therefore cannot replace the original link with the local one (at api/attachments/...). That means that the image is downloaded, but not linked in the note.

I tried replacing quotedUrl with url but still doesn't work.

In order to replicate:

• Create a new note
• Go to this linkedin profile (doesn't matter which one, let's take Bill Gates as an example): https://www.linkedin.com/in/williamhgates/
• Right click on his profile picture and "Copy Image"
• Paste into Trilium
• The image shows
• Go to "Note Source"
• See that's pointing to the original source, not the local one api/attachments/...

You can see in the developer console that's making requests to the 3rd party site every time you open the note.