GithubHelp home page GithubHelp logo

Comments (4)

Zal0 avatar Zal0 commented on June 25, 2024

Yes, you are right
I haven't changed this because to be honest I am not sure why SetTile is sometimes faster than set_bkg_tile_xy which is the function I wanted to use because it is the one that comes with GBDK
You are mentioning "proper times" in the description, what exactly do you mean?

from zgb.

ShenMansellPersonal avatar ShenMansellPersonal commented on June 25, 2024

by outside proper times I meant while VRAM shouldn't be written.

This can cause failures where the attribute data doesn't get written, and will also throw an exception in bgb or emulicious if they are enabled

SetTile is doing checks to avoid this by looping on STAT_REG & 2 before writing.

from zgb.

Zal0 avatar Zal0 commented on June 25, 2024

As far as i know set_bkg_tiles should be doing this too
The only reason why wrote SetTile back on the day is because set_bkg_tile_xy didn't exist. We have set_bkg_tiles which was slower because it expected an rect of tiles as entry param instead of a single tile
When set_bkg_tile_xy was added I did a little profiling and sometimes SetTile was still faster than set_bkg_tile_xy so I didn't change it

Anyways it should be either set_bkg_tile_xy in both calls or SetTile but not a mix so I'll change it

from zgb.

Zal0 avatar Zal0 commented on June 25, 2024

that fix from Toxa should fix the issue

from zgb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.