Comments (4)
Yes, you are right
I haven't changed this because to be honest I am not sure why SetTile is sometimes faster than set_bkg_tile_xy which is the function I wanted to use because it is the one that comes with GBDK
You are mentioning "proper times" in the description, what exactly do you mean?
from zgb.
by outside proper times I meant while VRAM shouldn't be written.
This can cause failures where the attribute data doesn't get written, and will also throw an exception in bgb or emulicious if they are enabled
SetTile is doing checks to avoid this by looping on STAT_REG & 2 before writing.
from zgb.
As far as i know set_bkg_tiles should be doing this too
The only reason why wrote SetTile back on the day is because set_bkg_tile_xy didn't exist. We have set_bkg_tiles which was slower because it expected an rect of tiles as entry param instead of a single tile
When set_bkg_tile_xy was added I did a little profiling and sometimes SetTile was still faster than set_bkg_tile_xy so I didn't change it
Anyways it should be either set_bkg_tile_xy in both calls or SetTile but not a mix so I'll change it
from zgb.
that fix from Toxa should fix the issue
from zgb.
Related Issues (20)
- Missing information in Music section of tutorial HOT 1
- MoveScroll( ... ) does not support jumping long distances HOT 1
- FadeOut() is broken on DMG HOT 1
- InitScroll() does not reset last_bg_pal_loaded (palettes get appended) HOT 5
- SGB Borders don't load on PAL Snes / Super GameBoy HOT 1
- Cannot compile without a Sprite
- Incorrect initialization of hUGEDriver HOT 1
- Default SaveGame Values HOT 2
- Possible imporvement to FadeStepColor HOT 1
- Error when compiling template HOT 3
- Problem with Enemies section. HOT 1
- Failure to use music HOT 10
- Problems displaying HUD Window in games compiled in Color mode when running on B/W hardware HOT 2
- Feature request: Add sprite flickering management
- [Request] [Docs] Debian/Ubuntu instructions for compiling in wiki HOT 4
- Errors with ZGB-template HOT 1
- .gbr needs to be in the same directory as .gbm HOT 1
- no way to make animation run once without looping HOT 1
- macOS build HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zgb.