GithubHelp home page GithubHelp logo

Comments (13)

falkTX avatar falkTX commented on May 26, 2024

the artwork is included in every plugin so that they can be completely self-contained.

generating the artwork before build is possible, but the user would need some extra things installed to be able to build the plugins (python3, numpy, pil).
while it's easy to get them on linux, the same is not true for osx and windows (but not sure how important this is for zamaudio).

in the future I hope we can do scalable plugin UIs.

from zam-plugins.

matze avatar matze commented on May 26, 2024

the artwork is included in every plugin so that they can be completely self-contained.

I just cannot see the use case or follow your argument: 1) there are no individual source packages for single plugins so why bothering with self-containment, 2) the plugins in the Git repo use the same shared dpf module, so the same could be true for assets and 3) the install target is missing in the plugin Makefiles, so they are not entirely self-contained anyway.

from zam-plugins.

falkTX avatar falkTX commented on May 26, 2024

I meant that the binary they produce is fully self-contained.
Duplicated images (or even code) in the source files is a different question.

from zam-plugins.

matze avatar matze commented on May 26, 2024

But I meant the duplication in the repository. I am not arguing against bundling the binaries with the data, that's a neat idea.

from zam-plugins.

zamaudio avatar zamaudio commented on May 26, 2024

@matze firstly, thank you for investing some time in this. When I created the image assets, I did not take into account that I would be reusing a lot of the assets. This certainly could be improved. I agree that the images are causing the clone time to be increased unnecessarily. I think it might be worth using some kind of git filter-branch to remove the artwork directories completely and reducing the size of the repo, then reintroducing the images in a proper framework. This could reduce the size of the repo considerably while keeping the git history mostly intact. I could certainly use some assistance in setting this up, but I have not got a lot of time to redo all the images like you have done with the new skin. BTW I do like your new slick skin theme 👍 . Can we work together to fix this?

from zam-plugins.

zamaudio avatar zamaudio commented on May 26, 2024

I don't think its a really good idea to increase the bitmap size, because it still needs to work on small screened laptops where I do my recording. Others may find this also to be the case, but I can't accommodate for everyone's 4K monitors unfortunately. It would be good to one day have scalable GUIs.

from zam-plugins.

actionless avatar actionless commented on May 26, 2024

It would be good to one day have scalable GUIs.

@zamaudio is related code resides only in https://github.com/zamaudio/zam-plugins/blob/master/widgets/ZamWidgets.hpp ? i am thinking about taking a try on it as part of c++ learning

or you want to switch from bitmaps to having sorta cairo-based toolkit?

from zam-plugins.

zamaudio avatar zamaudio commented on May 26, 2024

@actionless : see DPF. It is a submodule that handles the UI toolkit.

from zam-plugins.

falkTX avatar falkTX commented on May 26, 2024

nanosvg might be an option for scalable UIs.
See https://github.com/VCVRack/Rack for an example of an application that uses it to draw UI elements.

from zam-plugins.

Audiojunkie avatar Audiojunkie commented on May 26, 2024

Has there been any progress with support for HiDPI scaling? I use HiDPI for everything these days and generally leave behind all apps and tools for alternatives that scale ip for my screen. It would be nice to be able to use these plugins. HiDPI is much more prevalent now at the end of 2022 than things were back in 2017 when the last comment was posted. 🙂

from zam-plugins.

falkTX avatar falkTX commented on May 26, 2024

UIs will automatically scale up to the correct size, but will look blurry due to artwork being bitmap based.
The original SVGs are in the repo, eventually those will be used instead of bitmaps.

from zam-plugins.

actionless avatar actionless commented on May 26, 2024

should i set some env var or how it's getting desired dpi? i'm running bare window manager, so mb i am missing smth

from zam-plugins.

falkTX avatar falkTX commented on May 26, 2024

it gets them from X11 WM hints, but you can use DPF_SCALE_FACTOR env var to force one in particular, like 1.5 or 2

from zam-plugins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.