GithubHelp home page GithubHelp logo

Allow HTTPS request URIs about trifid-ld HOT 5 CLOSED

retog avatar retog commented on August 12, 2024
Allow HTTPS request URIs

from trifid-ld.

Comments (5)

bergos avatar bergos commented on August 12, 2024

The protocol field doesn't contain any information about SSL/TLS in newer version of node.js. This code should fix the problem:

if (this.socket.ssl) {
  absoluteUrl.protocol += 's'
}

from trifid-ld.

ktk avatar ktk commented on August 12, 2024

Just to clarify: The SSL request doesn't end up on node, I have an SSL terminator/proxy in front of Varnish and then Varnish sends it to the backend. But the dereferencing should be the SSL URI, not the non-SSL one.

from trifid-ld.

bergos avatar bergos commented on August 12, 2024

OK, even easier. Configure Varnish to send the 'x-forwarded-proto' header, express-utils will do the rest.

from trifid-ld.

ktk avatar ktk commented on August 12, 2024

I think we have a problem further up the chain, filed an issue in hitch with some details.

from trifid-ld.

ktk avatar ktk commented on August 12, 2024

After the feedback from the hitch maintainers I've added the following to my Varnish setup:

acl SSLfromlocalhost {
  "localhost";
}

sub vcl_recv {

  set req.http.X-Forwarded-Port = "80";

  # check if the request is comming from localhost, then it is from hitch (SSL terminator)
  if(client.ip ~ SSLfromlocalhost)
  {
    set req.http.x-forwarded-proto = "https";
    set req.http.X-Forwarded-Port = "443";
  }
...

from trifid-ld.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.