Comments (7)
Thanks, I'll look into it as soon as possible.
from plyrue.
@francoism90 I couldn't not reproduce on repository example. Can you maybe reproduce it on repo example, or provide more on how to reproduce?
Also, from what I seen on here sampotts/plyr#1505 and here sampotts/plyr#1441 it looks like it could be plyr's own problem.
from plyrue.
@zcuric Thanks for testing and taking a look at the error. :)
It seems it can be solved by destroying the player using the beforeDestroy
hook:
computed: {
player () {
return this.$refs.plyrue.player
}
},
beforeDestroy () {
this.player.destroy()
},
Don't know if the linked PR will fix this issue, or something else is causing it. It doesn't seem to be related to this package however. :)
from plyrue.
@francoism90 Thanks for feedback. We do destroy player in beforeDestroy
https://github.com/zcuric/plyrue/blob/master/src/components/Plyrue.vue#L43
If you encounter it again try to isolate it and please do give feedback again.
Cheers!
from plyrue.
@zcuric I've found out this seem to happen when using the autoplay
option.
As a workaround I'm now waiting for event ready
and wrap the instance in a try/catch just to prevent a warning from being shown:
https://github.com/francoism90/mediadb/blob/master/src/resources/js/components/player/Instance.vue#L65
from plyrue.
@francoism90 Can you maybe find a solution for this problem and submit a PR?
from plyrue.
@zcuric This seems to happen when using keep-alive. I've done some code refactoring on my side and the issue seem to be solved.
Thanks for looking into this issue!
from plyrue.
Related Issues (8)
- Custom controls? HOT 2
- Nuxt quality setting does not appear HOT 1
- SSR HOT 1
- Fullscreen does not appear in production mode. HOT 1
- Poster does not work HOT 12
- Webpack build throws mising dependency error HOT 4
- Add Typescript definitions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plyrue.