Comments (4)
Are the custom types only applicable to commits, but not PRs?
I'm not actually sure, as I didn't implement that feature and I don't use any custom types in my projects. You may have to jump into the code here to figure out how it's working. If PR titles are not being supported, I will happily accept a pull request that fixes that.
from semantic-pull-requests.
So after testing once again, I noticed that after merging .github/semantic.yml
to master, then every next PR will have the custom types. By default, only the pre-defined ones work, which is a weird behavior.
from semantic-pull-requests.
Ah yes that's expected behavior from Probot:
For security reasons, configuration is only loaded from the repository's default branch, changes made in pull requests from different branches or forks are ignored.
Thanks for following up. 👍🏼
from semantic-pull-requests.
Thank for clearing this up! It is good to be aware that this is the expected behaviour for Probot.
from semantic-pull-requests.
Related Issues (20)
- Empty space prefixing PR title should make the pr title invalid HOT 2
- Looking for maintainer(s) HOT 2
- Github IP allow list HOT 2
- Github Enterprise (GHE) App deployed successfully, but no status checks shown on PR HOT 5
- Feature request: support for fixup! (git commit --fixup) commits HOT 1
- Is semantic-pull-requests service down? HOT 15
- Opt-in check only by adding a configuration HOT 5
- Is it a issue? When there is no space after colon, PR is invalid HOT 2
- semantic PR check still not working HOT 24
- Semantic Pull Request test Fail ❌ HOT 1
- Node engine version HOT 10
- Semantic bot not working, no semantic entry in checks HOT 2
- feature: support optional scope in type HOT 4
- Add gitmoji acceptance HOT 1
- Service down HOT 24
- Github defaults to PR title for squash and merge HOT 1
- App stops working in aws/aws-sdk-js-v3 HOT 2
- Maintenance mode - Thanks! HOT 1
- It can use this flow with Gitlab? HOT 2
- Status check stuck in "Expected — Waiting for status to be reported" state HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from semantic-pull-requests.