beware of squashing single-commit PRs about semantic-pull-requests

[kewah]

@zeke it seems to have been fixed on GitHub side. I ran a test and it uses the PR's title for the commit message 👍

EDIT: It worked because I use Refined GitHub as @christopherscott pointed out #17 (comment)

PR:

Commit:

[piratefsh]

hi @kewah was your merge made as a squash and merge? I'm still facing this issue where GH still autopopulates single-commit squashes with the commit message instead of the PR title (see screenshot)

[kewah]

@christopherscott oh right! my bad, I do use Refined GitHub so that explains it

[zeke]

It works!

[kunalnagar]

@zeke

Hi there,

I'm having issues with single commit PRs still. I have no config file and am using the default GitHub app.

[frabonomi]

Any update? We could take a similar approach as this.

[zeke]

I haven't made time to work on this, but if anyone wants to open a PR for it, I'd be happy to review, merge, and deploy it!

[frabonomi]

Ok, I'm going to work on it and send a PR!

[zeke]

Sounds good!

[frabonomi]

Sorry @zeke, just to better understand the purpose of this repo: in which case would one use the default options and allow merging whenever at least one commit has a semantic message or the title of the PR is semantic?

For this fix what would you suggest to do:

1. fix the behavior of the handler when titleOnly option set to true in order to check by default the PR title, but in case there's only one commit then check the commit's message
2. create a squashMerging option to define the separate behavior

I feel the first option would be the best, but then the titleOnly name doesn't make much sense anymore. And I'm also not sure what was the rationale behind that option.

[kewah]

@piratefsh yes, it was a squashed and merged. I only have that enabled

[christopherscott]

@piratefsh I also don't see that this has changed - single commits, when squashed and merged, still seem to default to the commit title

@kewah are you using Refined Github by any chance?

[zeke]

Yep this is still an issue. Just bit me again. Would love a PR for this if anyone has the time!

[zeke]

Hey y'all. I just deployed a fix for this with #58. Give it a try and let me know if you have any issues!

[zeke]

#58 had to be rolled back, so this is still an issue.

[kunalnagar]

@zeke just checking in on what I posted above ☝️