GithubHelp home page GithubHelp logo

Comments (8)

zeke avatar zeke commented on June 10, 2024 1

#51 is related because it's about the process for signaling a breaking change.

from semantic-pull-requests.

levithomason avatar levithomason commented on June 10, 2024

Note, I just pushed another commit and it seems to have re-triggered the check and passed. The issue appears to be intermittent.

from semantic-pull-requests.

zeke avatar zeke commented on June 10, 2024

Thanks for reporting, @levithomason.

A fix for semantic message detection was shipped nine days ago: #16 -- was the previous incorrect status reported before that timeframe?

from semantic-pull-requests.

levithomason avatar levithomason commented on June 10, 2024

@zeke here's another example of a PR check that is stagnant at the time of writing. Note the number of title changes trying to correct the check:

microsoft/fluent-ui-react#336

image

from semantic-pull-requests.

zeke avatar zeke commented on June 10, 2024

Ah I see. Unfortunately you can't actually denote a breaking change using the PR title, as the BREAKING CHANGE string needs to be in the Body™ of one of the commits, not in the first line of the commit (aka the Subject™). This is how the Conventional Commits spec is defined.

I'm open to ideas on how to make this easier, whether that means changes to this bot or proposing a change to the Conventional Commits spec to which this bot adheres.

from semantic-pull-requests.

zeke avatar zeke commented on June 10, 2024

Related: #51

from semantic-pull-requests.

tunnckoCore avatar tunnckoCore commented on June 10, 2024

I don't see how #51 is related to that. The linked #336 simply just doesn't follow the spec.

from semantic-pull-requests.

zeke avatar zeke commented on June 10, 2024

I think this was a blip in the service. Feel free to re-open if this happens again.

from semantic-pull-requests.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.