app icon about semantic-pull-requests

[zeke]

Hey @C0ZEN thanks for the mockups!

I like the second one. I wonder though what they'll look like in the context of a pull request page, where they'll be much smaller and perhaps harder to recognize. Can you try mocking them up in that context?

[C0ZEN]

PNG:

SVG:

<?xml version="1.0" encoding="UTF-8"?>
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="64pt" height="64pt" viewBox="0 0 64 64" version="1.1">
<g id="surface4188528">
<rect x="0" y="0" width="64" height="64" style="fill:rgb(94.509804%,76.862745%,5.882353%);fill-opacity:1;stroke:none;"/>
<path style=" stroke:none;fill-rule:nonzero;fill:rgb(0%,0%,0%);fill-opacity:1;" d="M 36 0.511719 C 35.730469 0.511719 35.480469 0.621094 35.289062 0.8125 L 27.808594 8.289062 C 27.421875 8.679688 27.421875 9.320312 27.808594 9.710938 L 35.289062 17.191406 C 35.667969 17.570312 36.332031 17.570312 36.710938 17.191406 L 39.539062 14.359375 C 39.929688 13.96875 39.929688 13.339844 39.539062 12.949219 L 38.589844 12 L 39 12 C 43.960938 12 48 16.039062 48 21 L 48 48.679688 C 45.640625 49.800781 44 52.210938 44 55 C 44 58.859375 47.140625 62 51 62 C 54.859375 62 58 58.859375 58 55 C 58 52.210938 56.359375 49.800781 54 48.679688 L 54 21 C 54 12.730469 47.269531 6 39 6 L 38.589844 6 L 39.539062 5.050781 C 39.929688 4.660156 39.929688 4.03125 39.539062 3.640625 L 36.710938 0.8125 C 36.519531 0.621094 36.269531 0.511719 36 0.511719 Z M 13 2 C 9.140625 2 6 5.140625 6 9 C 6 11.71875 7.578125 14.179688 10 15.328125 L 10 48.679688 C 7.640625 49.800781 6 52.210938 6 55 C 6 58.859375 9.140625 62 13 62 C 16.859375 62 20 58.859375 20 55 C 20 52.210938 18.359375 49.800781 16 48.679688 L 16 15.328125 C 18.820312 13.988281 20.429688 10.9375 19.902344 7.777344 C 19.421875 4.988281 17.25 2.730469 14.480469 2.148438 C 13.992188 2.050781 13.488281 2 13 2 Z M 36 2.929688 L 37.410156 4.339844 L 35.460938 6.289062 C 35.179688 6.578125 35.089844 7.011719 35.25 7.382812 C 35.398438 7.761719 35.769531 8 36.167969 8 L 39 8 C 46.171875 8 52 13.828125 52 21 L 52 48.082031 C 51.671875 48.019531 51.339844 48 51 48 C 50.660156 48 50.328125 48.019531 50 48.082031 L 50 21 C 50 14.929688 45.070312 10 39 10 L 36.167969 10 C 35.769531 10 35.398438 10.238281 35.25 10.621094 C 35.089844 10.988281 35.179688 11.421875 35.460938 11.710938 L 37.410156 13.660156 L 36 15.070312 L 29.929688 9 Z M 13 4 C 13.351562 4 13.710938 4.039062 14.082031 4.109375 C 16.03125 4.519531 17.589844 6.148438 17.917969 8.121094 C 18.359375 10.667969 16.859375 12.949219 14.652344 13.722656 C 14.261719 13.859375 14 14.230469 14 14.652344 L 14 48.082031 C 13.671875 48.019531 13.339844 48 13 48 C 12.660156 48 12.328125 48.019531 12 48.082031 L 12 14.652344 C 12 14.230469 11.738281 13.859375 11.339844 13.722656 C 9.390625 13.03125 8 11.179688 8 9 C 8 6.238281 10.238281 4 13 4 Z M 19 32 C 18.445312 32 18 32.449219 18 33 L 18 35 C 18 35.550781 18.445312 36 19 36 C 19.554688 36 20 35.550781 20 35 L 20 33 C 20 32.449219 19.554688 32 19 32 Z M 24 32 C 23.445312 32 23 32.449219 23 33 L 23 35 C 23 35.550781 23.445312 36 24 36 C 24.554688 36 25 35.550781 25 35 L 25 33 C 25 32.449219 24.554688 32 24 32 Z M 29 32 C 28.445312 32 28 32.449219 28 33 L 28 35 C 28 35.550781 28.445312 36 29 36 C 29.554688 36 30 35.550781 30 35 L 30 33 C 30 32.449219 29.554688 32 29 32 Z M 34 32 C 33.445312 32 33 32.449219 33 33 L 33 35 C 33 35.550781 33.445312 36 34 36 C 34.554688 36 35 35.550781 35 35 L 35 33 C 35 32.449219 34.554688 32 34 32 Z M 39 32 C 38.445312 32 38 32.449219 38 33 L 38 35 C 38 35.550781 38.445312 36 39 36 C 39.554688 36 40 35.550781 40 35 L 40 33 C 40 32.449219 39.554688 32 39 32 Z M 44 32 C 43.445312 32 43 32.449219 43 33 L 43 35 C 43 35.550781 43.445312 36 44 36 C 44.554688 36 45 35.550781 45 35 L 45 33 C 45 32.449219 44.554688 32 44 32 Z M 13 50 C 13.339844 50 13.679688 50.03125 14 50.097656 C 14.738281 50.25 15.421875 50.558594 16 51 C 17.210938 51.910156 18 53.371094 18 55 C 18 57.761719 15.761719 60 13 60 C 10.238281 60 8 57.761719 8 55 C 8 53.371094 8.789062 51.910156 10 51 C 10.578125 50.558594 11.261719 50.25 12 50.097656 C 12.320312 50.03125 12.660156 50 13 50 Z M 51 50 C 51.339844 50 51.679688 50.03125 52 50.097656 C 52.738281 50.25 53.421875 50.558594 54 51 C 55.210938 51.910156 56 53.371094 56 55 C 56 57.761719 53.761719 60 51 60 C 48.238281 60 46 57.761719 46 55 C 46 53.371094 46.789062 51.910156 48 51 C 48.578125 50.558594 49.261719 50.25 50 50.097656 C 50.320312 50.03125 50.660156 50 51 50 Z M 51 50 "/>
</g>
</svg>

[C0ZEN]

PNG:

SVG:

<?xml version="1.0" encoding="UTF-8"?>
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="50pt" height="50pt" viewBox="0 0 50 50" version="1.1">
<g id="surface4190910">
<rect x="0" y="0" width="50" height="50" style="fill:rgb(94.509804%,76.862745%,5.882353%);fill-opacity:1;stroke:none;"/>
<path style=" stroke:none;fill-rule:nonzero;fill:rgb(0%,0%,0%);fill-opacity:1;" d="M 15 8 C 15 10.40625 13.273438 12.4375 11 12.90625 L 11 37.09375 C 13.273438 37.5625 15 39.59375 15 42 C 15 44.75 12.75 47 10 47 C 7.25 47 5 44.75 5 42 C 5 39.59375 6.726562 37.5625 9 37.09375 L 9 12.90625 C 6.726562 12.4375 5 10.40625 5 8 C 5 5.25 7.25 3 10 3 C 12.75 3 15 5.25 15 8 Z M 25 3 L 25 7 L 32 7 C 34.972656 7 37.621094 8.457031 39.257812 10.691406 L 38.640625 11.308594 L 37.835938 12.121094 C 36.585938 10.238281 34.441406 9 32 9 L 25 9 L 25 13 L 23.375 13 L 23.09375 12.78125 L 18.09375 8.78125 L 17.125 8 L 18.09375 7.21875 L 23.09375 3.21875 L 23.375 3 Z M 41 37.09375 C 43.273438 37.5625 45 39.59375 45 42 C 45 44.75 42.75 47 40 47 C 37.25 47 35 44.75 35 42 C 35 39.59375 36.726562 37.5625 39 37.09375 L 39 28.171875 L 41 26.1875 Z M 7 8 C 7 9.667969 8.332031 11 10 11 C 11.667969 11 13 9.667969 13 8 C 13 6.332031 11.667969 5 10 5 C 8.332031 5 7 6.332031 7 8 Z M 20.3125 8 L 23 10.15625 L 23 5.84375 Z M 7 42 C 7 43.667969 8.332031 45 10 45 C 11.667969 45 13 43.667969 13 42 C 13 40.332031 11.667969 39 10 39 C 8.332031 39 7 40.332031 7 42 Z M 37 42 C 37 43.667969 38.332031 45 40 45 C 41.667969 45 43 43.667969 43 42 C 43 40.332031 41.667969 39 40 39 C 38.332031 39 37 40.332031 37 42 Z M 37 42 "/>
<path style=" stroke:none;fill-rule:nonzero;fill:rgb(0%,0%,0%);fill-opacity:1;" d="M 45.027344 9.421875 C 44.027344 9.421875 43.128906 9.820312 42.328125 10.519531 L 42.128906 10.621094 L 42.027344 10.71875 L 41.027344 11.71875 L 40.828125 11.921875 L 29.128906 23.71875 C 29.027344 23.820312 28.929688 24.019531 28.828125 24.121094 L 27.128906 30.121094 C 26.929688 30.621094 27.226562 31.21875 27.828125 31.320312 C 28.027344 31.421875 28.226562 31.421875 28.328125 31.320312 L 34.328125 29.71875 C 34.527344 29.71875 34.628906 29.621094 34.828125 29.421875 L 47.628906 16.621094 L 47.929688 16.421875 C 49.527344 14.820312 49.527344 12.21875 47.929688 10.621094 C 47.128906 9.71875 46.027344 9.421875 45.027344 9.421875 Z M 45.027344 11.421875 C 45.527344 11.421875 46.128906 11.621094 46.527344 12.019531 C 47.328125 12.820312 47.328125 14.019531 46.628906 14.820312 L 43.726562 11.921875 C 44.128906 11.621094 44.527344 11.421875 45.027344 11.421875 Z M 42.226562 13.320312 L 45.226562 16.320312 L 34.328125 27.21875 L 31.328125 24.320312 Z M 30.328125 26.21875 L 32.429688 28.320312 L 29.527344 29.121094 Z M 30.328125 26.21875 "/>
</g>
</svg>

[C0ZEN]

Some thoughts:

• Color contrast is very good but the yellow a bit flashy for me 🟡
• Using a circle is problematic with GitHub allowing .png with transparent background but force to use a white background anyway style="background-color: #ffffff" (as seen as an action there is a white background and I do not like it very much due to the grey background surrounding the logo - check image below)
• The second logo is indeed not perfect for the GitHub action (the pen is not visible enough I think) - check image below

Current logo used for the GitHub action:
https://avatars1.githubusercontent.com/in/9517?s=40&v=4

Current logo display from the GitHub action:

Second logo display from the GitHub action:

@zeke multiple questions here:

• Do you wish to keep the same colors?
• Do you wish to keep the logo as a circle?

Thoughts:
I like the "PR schema" in the logo I provided but adding to it the notion of "this project check the semantic" is very hard due to not having enough space 😭
This idea could be provided with a color change (classical red/green to show that it "validates") but honestly I am not seeing this with a sexy eye.
I will provide another shot at this later but any advice is welcome 🙄

I just crossed this issue and provided a quick logo but please do not feel the need to change the logo if you are not confident enough about these propositions. You have all the time to find the perfect one 😄

[C0ZEN]

[zeke]

This issue is old and inactive so I'm going to close it. If anyone is still affected by this, let me know and I'll re-open it.