Comments (9)
I changed the PR title to start with lowercase build(deps):
and the check is now passing.
from semantic-pull-requests.
My takeaway from the discussion in conventional-commits/conventionalcommits.org#110:
Given that the Semantic Pull Requests bot is designed to play nicely with
semantic-release
which is case sensitive (lowercase required), I will probably update the bot to fail checks that are uppercase, but provide a helpful status message to indicate when the message would be valid if it was lowercase...
from semantic-pull-requests.
The thing is because there is missing i
flag in my regex :D
I'll update that through GitHub UI, but I'm trying to clean up tabs count... ;d
from semantic-pull-requests.
Wohoo
from semantic-pull-requests.
@tunnckoCore thanks for that, but that change to parse-commit-message
seems more like a breaking change than a fix, as it definitely changes behavior. I guess the best option at this point is to add caseSensitive
as a .github/semantic.yml
config option, and default it to true
, to avoid breaking users of semantic-release
.
from semantic-pull-requests.
parse-commit-message is an underlying tool, higher level tools such as Semantic Release and @standard-release should handle that through their configs so users can use it as you said.
I don't see it as breaking change, because no matter what's the commit style it will still work with package author case-sensitive and non-sensitive choice. If Semantic Release has such option - great, but @standard-release currently don't have such option.
No matter what commit style users of semantic-pull-requests
use they still will get the correct status check and won't have failing status check builds. I don't see how this can be breaking change for anyone at all.
I guess the best option at this point is to add
Are you talking about adding it to this repository config?
from semantic-pull-requests.
I don't see how this can be breaking change for anyone at all.
If a user of semantic-release
and semantic-pull-requests
shipped a squashed PR with capitalized title Fix: change something
, the fix would not trigger a release, because semantic-release
wouldn't recognize it as a semantic message.
add
caseSensitive
as a.github/semantic.yml
config option
I mean add case sensitivity as an option for users of the Semantic Pull Requests bot.
from semantic-pull-requests.
Oooooh, I see. Didn't thought for that sorry ;/
I mean add case sensitivity as an option for users of the Semantic Pull Requests bot.
Ah got it, yea sounds good.
from semantic-pull-requests.
This issue is old and inactive so I'm going to close it. If anyone is still affected by this, let me know and I'll re-open it.
from semantic-pull-requests.
Related Issues (20)
- Empty space prefixing PR title should make the pr title invalid HOT 2
- Looking for maintainer(s) HOT 2
- Github IP allow list HOT 2
- Github Enterprise (GHE) App deployed successfully, but no status checks shown on PR HOT 5
- Feature request: support for fixup! (git commit --fixup) commits HOT 1
- Is semantic-pull-requests service down? HOT 15
- Opt-in check only by adding a configuration HOT 5
- Is it a issue? When there is no space after colon, PR is invalid HOT 2
- semantic PR check still not working HOT 24
- Semantic Pull Request test Fail ❌ HOT 1
- Node engine version HOT 10
- Semantic bot not working, no semantic entry in checks HOT 2
- feature: support optional scope in type HOT 4
- Add gitmoji acceptance HOT 1
- Service down HOT 24
- Github defaults to PR title for squash and merge HOT 1
- App stops working in aws/aws-sdk-js-v3 HOT 2
- Maintenance mode - Thanks! HOT 1
- It can use this flow with Gitlab? HOT 2
- Status check stuck in "Expected — Waiting for status to be reported" state HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from semantic-pull-requests.