Comments (8)
+1 on this.
Our use case is the following: GitHub doesn't let you choose a default squash commit message. Squashing a pull request with one commit would use that commitโs message, but squashing a pull request with more than one commit will use the pull requestโs title for the commit message. We want to make sure that every single external contributor PR in our repo gets merged with a valid squash commit message so checking both would be beneficial for us.
Ideally we would be able to check the squash commit message only (so PR title for multiple commits, commit for single commit).
from semantic-pull-requests.
Got it. There's an open issue about squashing single-commit PRs: #17
I am pretty busy right now, but would happily accept and ship a PR that addresses this.
from semantic-pull-requests.
#46 @clakech I think you meant this PR of yours :)
from semantic-pull-requests.
Resolved by #46 -- this should be live within a few minutes.
from semantic-pull-requests.
๐ Thanks for reporting. You're right about the current behavior. Here's what we have now:
default behavior: validate title or at least one commit is semantic
titleOnly: true
: Always validate the PR title, and ignore the commits
commitsOnly: true
: Always validate all commits, and ignore the PR title
For what reason would you want to validate both the title and all commits? I'm not against it, but wondering about your use case.
from semantic-pull-requests.
@CecileRobertMichon would only allowing "squash merging" on the repo work for your case?
from semantic-pull-requests.
@zeke not exactly. We already only allow squash merging. The issue is that I can't control how many commits are in a pull request and GitHub is inconsistent when squash merging commits. If there is a single commit, the commit message comes from the commit. If there are multiple commits, the commit message comes from the PR title. So checking only the commits or only the title is not sufficient since either may be used at squash time.
from semantic-pull-requests.
We would like to have both to have consistency between PR titles and all commits
Here is a first implementation / proposal #42
from semantic-pull-requests.
Related Issues (20)
- Looking for maintainer(s) HOT 2
- Github IP allow list HOT 2
- Github Enterprise (GHE) App deployed successfully, but no status checks shown on PR HOT 5
- Feature request: support for fixup! (git commit --fixup) commits HOT 1
- Is semantic-pull-requests service down? HOT 15
- Opt-in check only by adding a configuration HOT 5
- Is it a issue? When there is no space after colon, PR is invalid HOT 2
- semantic PR check still not working HOT 24
- Semantic Pull Request test Fail โ HOT 1
- Node engine version HOT 10
- Semantic bot not working, no semantic entry in checks HOT 2
- feature: support optional scope in type HOT 4
- Add gitmoji acceptance HOT 1
- Service down HOT 24
- Github defaults to PR title for squash and merge HOT 1
- App stops working in aws/aws-sdk-js-v3 HOT 2
- Maintenance mode - Thanks! HOT 1
- It can use this flow with Gitlab? HOT 2
- Status check stuck in "Expected โ Waiting for status to be reported" state HOT 1
- Stuck waiting for Semantic Pull Request status to be reported
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from semantic-pull-requests.