Comments (5)
@onmyway133 Care to elaborate a bit more on this?
from spots.
@zenangst for now, the SpotsScrollDelegate
only notifies these 2 methods, would there be another method called spotDidScroll
or similar so that SpotsController
knows that the scrollView has scrolled
public protocol SpotsScrollDelegate: class {
func spotDidReachBeginning(completion: (() -> Void)?)
func spotDidReachEnd(completion: (() -> Void)?)
}
from spots.
@onmyway133 couldn't you just override scrollViewDidScroll
on the SpotsController
?
Right now you have an extension that handles the calling of the delegates.
The reason why I don't really like having spotDidScroll
is because it would have to be optional. So you would add a default implementation for it that does pretty much nothing. Also, you don't really scroll the spot, the scrolling is handled by spotsScrollView
.
Hope that is what you meant π
from spots.
Ahhhh, that is what I mean, thanks
from spots.
@onmyway133 π
from spots.
Related Issues (20)
- Add a test for checking the new `clean` property in `prepareItems`. HOT 1
- Method does not override any method from its superclass
- Improve naming of `itemsPerRow` HOT 12
- Update Example apps HOT 8
- CryptoSwift requirement 0.6.0 does not work with Xcode 9. HOT 4
- Building Scheme Spots-tvOS exit error 65 HOT 6
- no ad was available Apple TV os HOT 4
- Cant Play add HOT 1
- Item with uilabel not expanding with text after sizeToFit HOT 14
- Event handling HOT 3
- Enable linting HOT 1
- func configure(_ item: inout Item) change. HOT 5
- please add more visual example projects just like the cover image implied HOT 1
- Feature Request: Migration from HUB to Spots?
- ComponentDelegate is nil HOT 3
- compile error with Xcode 9.3
- weird problem on pop. HOT 1
- Documentation
- Child components
- Crash on iOS 13 Beta 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spots.