GithubHelp home page GithubHelp logo

Expose scrollViewDidScroll? about spots HOT 5 CLOSED

zenangst avatar zenangst commented on August 11, 2024
Expose scrollViewDidScroll?

from spots.

Comments (5)

zenangst avatar zenangst commented on August 11, 2024

@onmyway133 Care to elaborate a bit more on this?

from spots.

onmyway133 avatar onmyway133 commented on August 11, 2024

@zenangst for now, the SpotsScrollDelegate only notifies these 2 methods, would there be another method called spotDidScroll or similar so that SpotsController knows that the scrollView has scrolled

public protocol SpotsScrollDelegate: class {

  func spotDidReachBeginning(completion: (() -> Void)?)
  func spotDidReachEnd(completion: (() -> Void)?)
}

from spots.

zenangst avatar zenangst commented on August 11, 2024

@onmyway133 couldn't you just override scrollViewDidScroll on the SpotsController?

Right now you have an extension that handles the calling of the delegates.

The reason why I don't really like having spotDidScroll is because it would have to be optional. So you would add a default implementation for it that does pretty much nothing. Also, you don't really scroll the spot, the scrolling is handled by spotsScrollView.

Hope that is what you meant 😎

from spots.

onmyway133 avatar onmyway133 commented on August 11, 2024

Ahhhh, that is what I mean, thanks ☺️

from spots.

zenangst avatar zenangst commented on August 11, 2024

@onmyway133 😁

from spots.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.