UnboundLocalError: local variable 'token' referenced before assignment about matrix-registration

[zeratax]

yes that does sound sensible, thank you!

[jfmontanaro]

Ok, unfortunately it looks like Flask returns a 400 error when force_json=True and the request body is empty. This can be overridden by extending the default flask.Request class object with a custom on_json_loading_failed() method that returns None in that particular case. Not sure if this is worth the added complexity, however.

As an alternative we could also specify silent=False, which would cause get_json() to return None any time JSON parsing fails. This seems like a really bad idea to me though because it would result in the server silently substituting default values any time the user supplies invalid JSON, which would be surprising at best and catastrophic at worst (e.g. someone tries to create a one-time use token with a short lifetime and ends up creating an unlimited-use token that lives forever.)

What do you think? Worth customizing the Request class or no?

[jfmontanaro]

actually, wait - BadRequest is an exception, so we can just catch that and handle it. Let me just make sure that works.

Edit: Ok, looks like it does.

[seth586]

Getting the same error when attempting to list tokens as documented, related?

curl -H "Authorization: SharedSecret verysecuresecret" \
     http://localhost:5000/token

[jfmontanaro]

Looks like it could be related, does including a Content-Type: application/json header eliminate the issue?