Grid.isosurface for complex values? about sisl

[zerothi]

@pfebrer should we warn about complex data-type, and then only pass the float, or simply accept the warning that arises?

[pfebrer]

Hmm interesting, do complex value iso surfaces even make sense? Can you say that some complex value is larger/smaller than another? You would have to compute some real number out of them (e.g. the modulus) and then compute an isosurface for that, right?

If that's the case, I think a warning from our side wouldn't solve much. We could either keep the scikit-image warning or raise an error (which maybe is the best option).

[zerothi]

Yeah, probably the modulus would be the best thing, shouldn't we then silently do that for a complex grid?
In that case I would do something like this:

1. convert the grid to the modulus
2. define a projection angle (lets default to 0, real axis choice), then choose the sign of the modulus depending on the projection?

Or would you do something else?

[pfebrer]

I'm not sure if we should do anything silently 😅 In any case, I would do it only if the isosurface level requested by the user is also a complex value, so that we are more certain that this is what the user wants to do.

Otherwise I would raise an error.

[zerothi]

I'm not sure if we should do anything silently 😅 In any case, I would do it only if the isosurface level requested by the user is also a complex value, so that we are more certain that this is what the user wants to do.

Otherwise I would raise an error.

Asking for a complex isosurface would be horrendous :)
It will be individual points, I think perhaps the modulus would be the most appropriate.