GithubHelp home page GithubHelp logo

Comments (5)

zeruniverse avatar zeruniverse commented on July 20, 2024

There'll be tons of cases that user can make this fields broken. I think as
long as it can be JSON.parse(), we can take it.

For linebreak, I'll remove the new line or space at the end or beginning.

On Thursday, 17 March 2016, Benjamin Häublein [email protected]
wrote:

If you insert a linebreak when customizing fields the javascript code
can't be executed because there will be a linebreak in a string literal.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#23

from password-manager.

BenjaminHae avatar BenjaminHae commented on July 20, 2024

Problem is: If you change fields to contain a linebreak, everything is broken. You can't access your account and change it back.

from password-manager.

zeruniverse avatar zeruniverse commented on July 20, 2024

I realized it. I think just need to remove all spaces and new lines at the
beginning or end.

Is it right?
On Thursday, 17 March 2016, Benjamin Häublein [email protected]
wrote:

Problem is: If you change fields to contain a linebreak, everything is
broken. You can't access your account and change it back.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#23 (comment)

from password-manager.

BenjaminHae avatar BenjaminHae commented on July 20, 2024

The way I would prefer is removing the linebreaks when reading the fields from the database. But only the first time, not when reading them for the textarea. That way the user may format it nicely.

from password-manager.

zeruniverse avatar zeruniverse commented on July 20, 2024

Fixed by 5fbe322

from password-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.