Comments (12)
I looked into it a while ago, the problem is, that after the alert the whole page is reloaded, so it's not that easy to implement.
It would be better practice to just reload the table and tags after editing/adding/deleting an account - then showing a notification instead of an alert would be trivial.
from password-manager.
We can use Ajax. That is, put all dynamic contents in a seperate php file.
But yes, it's not a trivial work.
On Thursday, 16 June 2016, Benjamin HΓ€ublein [email protected]
wrote:
I looked into it a while ago, the problem is, that after the alert the
whole page is reloaded, so it's not that easy to implement.
It would be better practice to just reload the table and tags after
editing/adding/deleting an account - then showing a notification instead of
an alert would be trivial.β
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#55 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AEbvNAuHbgmJ733eUbyY7Hrebkdpj4Tuks5qMUIqgaJpZM4I2Zb3
.
from password-manager.
Well For me the messages are not needed anyway. Can't you just disable them?
from password-manager.
Temp solution for you: open password.php using notepad, search for 'alert'
and delete all of them.
On Thursday, 16 June 2016, Nick [email protected] wrote:
Well For me the messages are not needed anyway. Can't you just disable
them?β
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#55 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AEbvNI3uS6nV9WhsqCMRc-2YXX03-Uiiks5qMfgLgaJpZM4I2Zb3
.
from password-manager.
Yeah I already did this for now.
Just thought this is a general improvement that I should report.
from password-manager.
I'll give it a try.
from password-manager.
Thanks Benjamin
from password-manager.
@nickbe I think I've got it, but as this is a major change I'd be glad if you tested it before I'll merge it to the master branch. You just need the files src/password_ajax.php
and src/password.php
from my development branch
from password-manager.
I'll test this later today and report the results to you.
from password-manager.
There seems to be a problem with refreshing the view after deleteing an entry.
Entry is still visible and can be even openend, but after F5 it's gone.
Otherwise the messages look really fine this way.
from password-manager.
@nickbe thanks. It should work now. I just pulled everything to master.
from password-manager.
Will update the live system tonight.
Thanks!!!
from password-manager.
Related Issues (20)
- Enable Group by Tags default HOT 2
- sort by name HOT 2
- random_login_stamp HOT 7
- Positive comment and thank you HOT 3
- Extra table td before username HOT 6
- Import problem with Username filed HOT 1
- Is this still active and mainteined? HOT 6
- Complete rework HOT 1
- Import CSV failed. HOT 4
- Replace SHA512 with SHA3-512 HOT 3
- Move to maintainance mode HOT 2
- Upgrade plugin to support v11.00 HOT 4
- PIN doesn't work on newest version HOT 5
- Cannot read property 'importKey' of undefined HOT 2
- TypeError: Cannot convert undefined or null to object AFTER LOGIN HOT 4
- New Implementation is ready HOT 1
- what is the password HOT 6
- Cannot run version 11: error 'sorry-update-your-browser' or am I not meeting the minimum requirements? HOT 1
- Can no longer copy password to clipboard without revealing it? HOT 2
- Current web browser doesn't support the technologies in Android 8.1 HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from password-manager.