GithubHelp home page GithubHelp logo

Comments (6)

zeruniverse avatar zeruniverse commented on July 20, 2024

This is easy to implement. But it's not safe and I don't think people will change email address. You can modify your email in database anyway

from password-manager.

nickbe avatar nickbe commented on July 20, 2024

Not safe? Why?

from password-manager.

zeruniverse avatar zeruniverse commented on July 20, 2024

Sorry. In the version I use, I integrated email verification.

I just took a look at the version on Github. Seems we don't need email at
all. That's a redundant.

On Thursday, 16 June 2016, Nick [email protected] wrote:

Not safe? Why?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#56 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AEbvNDnXfBWlzH0Id2VBzBAhkufLdlDTks5qMfebgaJpZM4I3Odo
.

from password-manager.

nickbe avatar nickbe commented on July 20, 2024

So if we could simply enter mail adresses as user names?
Is it possible to change the username? Does that lead to problems?

from password-manager.

zeruniverse avatar zeruniverse commented on July 20, 2024

I'll consider remove the email feature. It isn't used anywhere.

On Friday, 17 June 2016, Nick [email protected] wrote:

So if we could simply enter mail adresses as user names?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#56 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AEbvNBKEAdNcPiOowZfFFyhlJzwCSRd4ks5qMl0MgaJpZM4I3Odo
.

from password-manager.

zeruniverse avatar zeruniverse commented on July 20, 2024

Ok I took a look at the project. The email field was introduced in the first commit 4ea00d2. And I noticed the first version has the feature of email verification so it's necessary to have an email field. But later I removed this feature as I noticed the implementation of sending emails might vary and not all people want this. Meanwhile I put it in README as possible extensions.

Yes, I can confirm for current version, the email field does nothing. But I think it's better to keep it because then adding email verification feature doesn't involve in database change. As for the option to change email address, it seems this is only useful if email does something while it actually doesn't. So I won't implement it.

from password-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.