Comments (5)
Thanks a lot, you can remove the file now (and note my e-mail address /github name/ (at) [not-cold]mail {dot com} )
As for the genre bug, it comes from the fact that the Genre is formatted as (0)Blues
, which kinda tells the same information twice. I didn't expect that layout when coding genre extraction. That's fixed now and should be available on next release 😄
from atldotnet.
Hey Mike,
Thanks for your precious feedback!
I have some files with BOM in the id3 fields that ATL doesn't trim, as well as other files with whitespace. Can ATL trim these?
You're actually pointing a guiding principle I've been following : don't alter any data while reading or writing it. In other words, what you set is what's written / what's in the file is what you get - even if there are BOMs and whitespaces ;)
Another argument is I haven't seen other similar libraries doing that. Their added value is the standard API they provide to hide the complexity of formatting and writing the right bytes at the right place. Unless ID3/vorbis/M4A specifications explicitely say whitespaces have to be trimmed, guessing which data should be cleaned up or which data is "valid" is the user's problem, not the library's.
Also I noticed sometimes I have Genre doubled, like Blues;Blues, Other;Other, or Rock;Rock. Can ATL just use the first one it finds? Actually i don't see it in the tags more than once, so I'm not sure where this comes from.
If you're unsure where it comes from, I'd love to see a sample for that one :)
from atldotnet.
@mikeatdjp Are you still interested in solving the 2nd part of that issue ? Or is it obsolete to you ?
from atldotnet.
Hi @Zeugma440 ,
Thanks for your reply. I am interested, I've just been on another project.
Another argument is I haven't seen other similar libraries doing that. Their added...
I actually found this comparing a large collection of tags processed by ATL to the same collection processed by TagLib. I just double checked and made sure we were not doing any extra trimming with TagLib but I had to add in the trimming when using ATL to match TagLib results. Also I remember inspecting some of these different tags in mp3tag and I didn't see the extra spaces in mp3tag. And of course BOM isn't visible anyway.
I saved some sample files, but I couldn't tell what your email was last time. Where should I post these? I just attached it here. We can remove it if that's not right.
from atldotnet.
Fix is available on today's v4.34
from atldotnet.
Related Issues (20)
- Add support ENCODEDBY HOT 9
- get image HOT 1
- Ambisonic bwav files cannot be written and don't throw an exception HOT 5
- wav file duration is not determined HOT 2
- OptimFROG blind tags HOT 6
- long .ogg file loading HOT 3
- more understandable name HOT 6
- Chinese encoding exception HOT 6
- Reading MP3 files whose ID3v2 tags contain multiple PRIV frames HOT 14
- Doesn't work with .mp4 HOT 13
- track artist has invisible spaces? HOT 8
- Feature Request: Adding support for writing /mp42/isom m4a tags HOT 6
- Re-creating Track.AdditionalFields causes tag duplication HOT 3
- Issues when reading/modifying MP4 files containing MDAT atoms with 64bit lengths HOT 15
- Can't add a tag HOT 2
- The `AudioFileIO` reads HEIC file endlessly HOT 6
- Slow performance when re-tagging HOT 2
- Library fails to correctly parse date for flac files with more than one "Year" tag HOT 4
- Insufficient Characters Read HOT 6
- When LRC formatting fails, it results in other fields being incorrect.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from atldotnet.