"MPEGMode is not defined" about lamejs

[isolin]

Hi Don, same here! The previous fix unfortunately caused some issues with modules relying on implicitly & improperly loaded submodules. The following changes fix at least my pipeline, I hope yours as well. Until there is a new version out, you need to edit the respective files in your node_modules/lamejs folder. After the filename I give the line number to insert the requirement.

Lame.js:29
Encoder.js:112
PsyModel.js:162
all need var MPEGMode = require('./MPEGMode.js');

BitStream.js:33
Presets.js:18
both need var Lame = require('./Lame.js');

QuantizePVT.js:54
needs var BitStream = require('./BitStream.js');

[jgentes]

The issue is fixed in the latest release on Github, just not on NPM apparently. You can use this as a workaround in your package.json:

"dependencies": {
    "lamejs": "github:zhuker/lamejs"
}

[MrAlekhin]

I have the same issue still. Why is it closed?

[vanphucLE]

Declaring global variables can help:

import MPEGMode from 'lamejs/src/js/MPEGMode';
import Lame from 'lamejs/src/js/Lame';
import BitStream from 'lamejs/src/js/BitStream';


window.MPEGMode = MPEGMode;
window.Lame = Lame;
window.BitStream = BitStream;

[spicemix]

I was using this approach to linking with unreleased deps for a while and it was working, but at the moment for me neither that approach nor direct linking to 1.2.1 works. This issue shouldn't have been closed yet; we need a working release thanks!

(BTW, I found that unlinking on both ends and re-linking did the trick, but a new release would be so much easier)

[viniciusgusmao]

The issue is fixed in the latest release on Github, just not on NPM apparently. You can use this as a workaround in your package.json:

"dependencies": {
    "lamejs": "github:zhuker/lamejs"
}

Great! Worked for me.

[Specy]

Also having the same issue with sveltekit, waiting for PR to be merged and new version deployed

[tommy-banana]

I'm still having to make these manual changes despite using 1.2.1.

[tommy-banana]

Ok sorry. I must have done the manual fix - which is pretty easy to do. Tom Bancroft [phone] Sent from my iPhone

…

On 9 Apr 2022, at 09:21, Sergey ***@***.***> wrote:  Try audio-encoder npm . works. it seems audio-encoder uses lamejs and i have the same err ;( just copied their example to my app ***@***.*** — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.

[Selithrarion]

Try audio-encoder npm . works.

it seems audio-encoder uses lamejs and i have the same err ;(
just copied their example to my app
Selithrarion/vue_audio-tools@391fd2f

[T0914]

Any update on this conversation guys ? I have the same issue

[dadodasyra]

same issue too

[Selithrarion]

still

[tommy-banana]

Try audio-encoder npm . works.

[wug-ge]

It's pretty dirty, but this repo fixed it for me if you don't want to manually each time:
https://www.npmjs.com/package/lamejstmp

It's dirty as hell of course, I hope this gets resolved.

Also, this repo might do what most people want with less boilerplate, it has lamejs bundled into it and doesn't suffer from this issue:
https://github.com/closeio/mic-recorder-to-mp3

[Digglit]

Is there something I'm missing about this? The issue has been closed for a while, but I am still experiencing the same problem. This fix works, when can it be expected to be included in production?

Hi Don, same here! The previous fix unfortunately caused some issues with modules relying on implicitly & improperly loaded submodules. The following changes fix at least my pipeline, I hope yours as well. Until there is a new version out, you need to edit the respective files in your node_modules/lamejs folder. After the filename I give the line number to insert the requirement.

Lame.js:29 Encoder.js:112 PsyModel.js:162 all need var MPEGMode = require('./MPEGMode.js');

BitStream.js:33 Presets.js:18 both need var Lame = require('./Lame.js');

QuantizePVT.js:54 needs var BitStream = require('./BitStream.js');

[KhoaTheBest]

@viniciusgusmao it doesn't work for me :(

[TVNielsen]

@viniciusgusmao it doesn't work for me :(

could be you're using mic-recorder like i was and this one carries a 3 year old version of lamejs which you will have to manually override, even with this solve from @jgentes
at least i did, although it somewhat contradicts my understanding of it having lamejs as a dependency, here's sharing hope you can use it to solve your issue too

[KhoaTheBest]

@TVNielsen Im using lamejs directly

[TVNielsen]

i was too, but also using another module which also was and it was that module that didn't pick up the direct github reference or in any effect ended up having an internal version of lamejs which was at least not the one with the updated code for the example above direct. So in my case it was the same file which would error in the lamejs version without the direct github link or well at least another than this, and finding that folder and replacing it with the suggested one pulled from git also, did solve the problem. Seems it is some change to parent scope variables which was impacting the library. Den ons. 11. jan. 2023 kl. 02.45 skrev Khoa Le ***@***.***>:

…

@TVNielsen <https://github.com/TVNielsen> Im using lamejs directly — Reply to this email directly, view it on GitHub <#86 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABUHDKGCZ56BPKWEEIUUSJLWRYGD5ANCNFSM5JSNTU4A> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Med venlig hilsen, *Thomas V. Nielsen* email: ***@***.*** Telefon: [phone]

[digiage]

@viniciusgusmao it doesn't work for me :(

have you done npm install after changing package.json ?