GithubHelp home page GithubHelp logo

Improve OG description parsing about zine HOT 5 CLOSED

zineland avatar zineland commented on July 17, 2024
Improve OG description parsing

from zine.

Comments (5)

kiyov09 avatar kiyov09 commented on July 17, 2024

@Folyd
I'm interested in this one too. I want to start helping on the rust side of things.

from zine.

Folyd avatar Folyd commented on July 17, 2024

Wow, thanks. To help you get started: the extract_description() function is the point we need to improve and find_map() is the culprit of this issue.

/// Extract the description from markdown content.
///
/// The strategy is extract the first meaningful line,
/// and only take at most 200 plain chars from this line.
pub fn extract_description(markdown: &str) -> String {
markdown
.lines()
.find_map(|line| {
// Ignore heading, image line.
let line = line.trim();
if line.is_empty() || line.starts_with(['#', '!']) {
None
} else {
let raw = strip_markdown(line);
// If the stripped raw text is empty, we step to next one.
if raw == "\n" || raw.is_empty() {
None
} else {
// No more than 200 chars.
// Also, replace double quote to single quote.
Some(raw.chars().take(200).collect::<String>().replace('"', "'"))
}
}
})
.unwrap_or_default()
}

from zine.

kiyov09 avatar kiyov09 commented on July 17, 2024

Yeap. I was taking a look at that function previously. It works fine but only returns up to 200 chars of the first meaningful line.
In this case "Dear Rustaceans," is the whole line.
What do you think should be the new behavior?

from zine.

Folyd avatar Folyd commented on July 17, 2024

I don't think the first meaningful line is enough, such as in this case. The better approach is to extract at most 200 chars no matter how many lines.

from zine.

Folyd avatar Folyd commented on July 17, 2024

Close via #170.

from zine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.