connections opened but never closed about pacote

[silverwind]

Just wondering why this fix hasn't propagated to npm yet. Is it because npm/cli depends on pacote@8?

[tareqhs]

Found it !!

The custom agent in https://github.com/TooTallNate/node-agent-base does receive the automatic 'free' event from the underlying socket after the various fetching libraries finish using it but does nothing with it. Technically, this should be used for pooling and reusing TCP connections.

Since the agent does not pool stuff, we should simply close the sockets when they are free by calling socket.end() explicitly. My fix is to close them but I think we should reuse connections in a future improvement.

TooTallNate/node-agent-base#18

[tareqhs]

hi @zkat , @tgandrews , this is related to my comments in #109

[zkat]

Yes, I'm aware -- I just don't know why those connections are staying alive, is the issue. If you manage to track -that- down, that'd be super useful. Last I looked, it was literally only happening when using the proxy libraries.

[zkat]

I still think this probably has to do with https-proxy-agent, specially since it's a thing that happens when you proxy. There's relatively little I can do on the pacote and make-fetch-happen end of things if that library is... messing up closure. Can you look into it over on that end? If anyone else is willing to do the necessary sleuthing here, that would be -lovely- (/cc @TooTallNate)

[zkat]

omg good job! So excited. I hope this finally resolves this nonsense. 🎉

[jjimenez]

If I'm reading this right, once make-fetch-happen references agent-base 4.2.1 (pull request: zkat/make-fetch-happen#66), pacote can be updated to reference the right version of make-fetch-happen. Once pacote has the right version, npm can be updated since, as of v6.8.0-next.2, it references the latest pacote.

[shartte]

NPM 6.9.0 has fixed this issue for me.

[camueller]

Same here - using NPM 6.9.0 "npm i" runs fine using HTTP proxy.