GithubHelp home page GithubHelp logo

Removing getnet about orc HOT 3 CLOSED

zmarch avatar zmarch commented on July 28, 2024
Removing getnet

from orc.

Comments (3)

UlrichBerntien avatar UlrichBerntien commented on July 28, 2024

I prefer a new implementation of getnet. The code is very complex I fear to destruct the function if I try to fix only the shellcheck warnings.

I consider to implement parts in awk (mawk and POSIX awk compatible) because in awk is a powerfull language. A pure shell script could also an option. If a good shell code becomes to hard a perl script and a python script could be a fallback; better to support systems with perl or python than supporting no system. Today I have not a conclusion.

Likely an implementation with several helper functions, e.g. a ipconfig/ip link wrapper, will be a good solution. Also ipcalc/other solution is a candidate for a wrapper function.

In the mean time we could create a branch, named getnet_rework or simlar, with the getnet function and with "getnet() { echo 'comming soon back' }" in the master branch.

from orc.

zMarch avatar zMarch commented on July 28, 2024

I think a new branch for a rework is an excellent idea; just created one. I'll remove getnet from master when I get the chance. Having collaboration on getnet this time will hopefully mean the code won't be so complex and bad!

from orc.

zMarch avatar zMarch commented on July 28, 2024

Getnet clutter removed! now to develop something better

from orc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.