GithubHelp home page GithubHelp logo

Comments (7)

kyranjamie avatar kyranjamie commented on May 27, 2024 2

The SIP defines how this feature should work, and should be used as the guiding specification for the feature.

from ledger-stacks.

neithanmo avatar neithanmo commented on May 27, 2024 1

At a first glance, I do not see any reason to not be compatible as there is a clear definition for the message header..also the domain can be displayed on the screen along with the structured message hash as this field can change from message to message.

from ledger-stacks.

markmhx avatar markmhx commented on May 27, 2024

Note this is needed to fully complete hirosystems/wallet#2433

from ledger-stacks.

neithanmo avatar neithanmo commented on May 27, 2024

I will start to look into this.. have there been made any updates regarding implementation details??

from ledger-stacks.

markmhx avatar markmhx commented on May 27, 2024

Not that I'm aware of. @kyranjamie do you know of any?

Should we sync with developers who've implemented message signing already and see if they have any particular structured-data needs that might change our plans here?

from ledger-stacks.

janniks avatar janniks commented on May 27, 2024

Will we run into the same issue of incompatible/unallowed message signing prefix from the ledger side?

from ledger-stacks.

markmhx avatar markmhx commented on May 27, 2024

I haven't had a chance to review SIP-018 in depth yet, but presumably we'd have to upgrade the Stacks app for Ledger to support the prefix here: https://github.com/stacksgov/sips/pull/57/files#diff-cdf5e1eaffca20cd4bf675d2986bdf568c9c25cc79e119c961863b49701c6f75R118

@neithanmo do you have a decent sense from the SIP-018 just what scope of work would be involved for this enhancement on your end?

from ledger-stacks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.