Comments (7)
The SIP defines how this feature should work, and should be used as the guiding specification for the feature.
from ledger-stacks.
At a first glance, I do not see any reason to not be compatible as there is a clear definition for the message header..also the domain can be displayed on the screen along with the structured message hash as this field can change from message to message.
from ledger-stacks.
Note this is needed to fully complete hirosystems/wallet#2433
from ledger-stacks.
I will start to look into this.. have there been made any updates regarding implementation details??
from ledger-stacks.
Not that I'm aware of. @kyranjamie do you know of any?
Should we sync with developers who've implemented message signing already and see if they have any particular structured-data needs that might change our plans here?
from ledger-stacks.
Will we run into the same issue of incompatible/unallowed message signing prefix from the ledger side?
from ledger-stacks.
I haven't had a chance to review SIP-018 in depth yet, but presumably we'd have to upgrade the Stacks app for Ledger to support the prefix here: https://github.com/stacksgov/sips/pull/57/files#diff-cdf5e1eaffca20cd4bf675d2986bdf568c9c25cc79e119c961863b49701c6f75R118
@neithanmo do you have a decent sense from the SIP-018 just what scope of work would be involved for this enhancement on your end?
from ledger-stacks.
Related Issues (20)
- Wrong/unknown error code for `AppDoesNotSeemToBeOpen`
- Support JWT signing for Stacks authentication HOT 5
- Unable to retrieve keys for `m/888'` derivations paths
- Publish js app `v0.22.3` HOT 1
- Update data key derivation path HOT 1
- NPM published version is different than github HOT 2
- Display Domain name when signing JWT messages HOT 1
- Issues signing `principalCV` clarity types HOT 2
- Adjust `Stacks Signed Message` length prefix HOT 1
- Use varuint encoding for message prefix HOT 2
- Rename & publish npm package under `@zondax/ledger-stacks` HOT 2
- Replace buffer usage with Uint8Array HOT 1
- Message signing: payloads not accepted, line break issues HOT 3
- Contract principal not displayed properly on Ledger screen HOT 4
- Ledger Nano S screen showing incorrect address (40 instead of 41 characters) HOT 4
- Reduce the app size
- Fix CI HOT 1
- Update zxlib HOT 1
- Add new S+ sdk HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ledger-stacks.