GithubHelp home page GithubHelp logo

Comments (7)

bmueller avatar bmueller commented on May 13, 2024

This happens on iOS 7 as well. If I present a modal, then start and cancel an interactive transition, and then rotate the device, the presenting view does not rotate along with the modal.

In addition, if I present a modal view from landscape, the modal is presented from the wrong direction and does not fit the frame.

from zfdragablemodaltransition.

bmueller avatar bmueller commented on May 13, 2024

Actually, the latter issue I mentioned was already fixed, I was working from an older version.

The first issue (rotation gets messed up if you start dragging modal to dismiss it, then cancel the dismiss by dragging the modal back) is still happening in the latest version. You can reproduce this in the demo project via these steps:

  1. Set modal background to transparent.
  2. Run the demo app, then display the modal from the bottom.
  3. Drag down on the modal window, then drag back up so the modal doesn't dismiss.
  4. Rotate the device.

The presenting view in the background doesn't rotate with the device - it only updates to the correct orientation when you dismiss the modal view.

from zfdragablemodaltransition.

zoonooz avatar zoonooz commented on May 13, 2024

After I tried many ways to fix that in ios7, the rotation methods in presentingViewController never get called after drag to dismiss, not like in ios8. So I assume that is a bug in iOS7. I think I going to rotate that layer manually. Sorry

from zfdragablemodaltransition.

zoonooz avatar zoonooz commented on May 13, 2024

@bmueller please try this commit.

BTW I will keep this issue open for ios8. I will fix it later

from zfdragablemodaltransition.

bmueller avatar bmueller commented on May 13, 2024

Looks like it's working in the demo now, though in my app when I rotate from portrait to landscape, the background view does rotate but it has a big gray bar covering the right half of the screen. Probably something to do with my implementation, I'm guessing.

from zfdragablemodaltransition.

anasb avatar anasb commented on May 13, 2024

Not the same issue, but might be related: On iOS 8 (iPhone Simulator), if you dismiss without the animation, it doesn't bring the view back to the front. It stays pushed in with black edges around it. If you repeat the operation it pushes it more and more.

from zfdragablemodaltransition.

zoonooz avatar zoonooz commented on May 13, 2024

@anasb I just create the issue here #12 .

from zfdragablemodaltransition.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.