GithubHelp home page GithubHelp logo

Comments (6)

eshton avatar eshton commented on May 18, 2024

We have to investigate the maximum length of the player's name and set the size of that box so it will fit in all the time. I think the icon should be smaller as well.

from cupapp.

zsol avatar zsol commented on May 18, 2024

The max length of an SC2 nickname is 12 characters currently.
I'd say let's make it 200px wide, so the left panel would be 360px then. Agree?
I'll upload even smaller icons soon

from cupapp.

eshton avatar eshton commented on May 18, 2024

I believe is you just make the icon smaller then it will resolve this problem. Also, the example disappeared :D

from cupapp.

zsol avatar zsol commented on May 18, 2024

The example is here: http://test.cupapp.com/en/replay/view/7/1v1-Lost_Temple-LiquidHuK-IMJunwiPirme

I have set the players panel to 200px and made the icons smaller. I still think it's possible for player names to be too long (i.e. "MMMMMMMMMMMM" would probably not fit), but I have also noticed that giving a really long description for a replay also screws up the layout so we might have to come up with a more dynamic one. Example: http://test.cupapp.com/en/replay/view/12/Nemtudni-Metalopolis-Flint-Zsol-sHadowLigHt-Stylosa

from cupapp.

eshton avatar eshton commented on May 18, 2024

Put the description field in a paragraph tag and add the next styles:
width: 260px;
word-wrap: break-word;

from cupapp.

zsol avatar zsol commented on May 18, 2024

this is now fixed in the latest commit

from cupapp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.