Comments (6)
@borisyankov why add container components?
from zulip-mobile.
Mostly for separation of concerns. Sometimes for better reusability, but not always.
I've also used before it to convert from Immutable to plain JS objects, but not sure it was consistently a good idea.
Generally a container will take care of retrieving the data (from Redux, via fetch, etc.) but will just render a single component. The behavior and view will be in this component, but it will be 'dumb' about where the data is coming from.
Some of the ideas come from:
https://medium.com/@dan_abramov/smart-and-dumb-components-7ca2f9a7c7d0#.fakt3m8o4
and some from other discussion places and personal experience.
from zulip-mobile.
I think we can wait to do this kind of refactoring until it becomes a bigger problem. Thoughts?
from zulip-mobile.
Also, I'm not sure it's worthwhile to add Flow types to the API calls. Flow is a static type checker but the API results are dynamic, so it won't really be able to do any checking with those types.
from zulip-mobile.
@neerajwahi Yeah, I wanted to document the goals more than necessarily put it as priority.
New stuff will follow this, but not going to rework everything that was written (did the Zulip removing because it was trivial)
from zulip-mobile.
Closing as 'complete'.
from zulip-mobile.
Related Issues (20)
- Support "support" stream type with topic-specific permissions
- Support better management of names of archived streams
- Support independent "resolve topic" permission HOT 1
- Check what needs to be done to support phase 1 priority group permissions
- Notification badge count not showing in iOS HOT 1
- Image thumbnails won't load on Android Zulip app when reverse proxied through Cloudflare HOT 3
- Check our Apple "privacy manifest" HOT 1
- Quote and reply does not quote LaTeX correctly
- Add "Recent conversations" view HOT 1
- Mobile app uses a different icon for "All messages" than the desktop app HOT 1
- msglist: Long-press on invalid link crashes the app
- Recognize "channel" as operator in narrow links
- Generate narrow links using "channel" operator, not "stream", if server is recent HOT 3
- Parse topic permalinks
- Fuzzy keyword search needed HOT 2
- Support "support" stream type with topic-specific permissions HOT 1
- Support new settings for restricting direct messages HOT 5
- Check / fix table border color in dark mode HOT 5
- Notify users when they are DMing a guest based on setting
- Make use of thumbnails HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zulip-mobile.