GithubHelp home page GithubHelp logo

Comments (8)

zulipbot avatar zulipbot commented on July 18, 2024

Hello @zulip/design members, this issue was labeled with the "design" label, so you may want to check it out!

from zulip.

PieterCK avatar PieterCK commented on July 18, 2024

Hello. I think it's because of this specific rule:
image
Deleting the color: hsl(0, 86%, 40%); on a:hover removes any color change on a tag stuff including typeaheads. Similar to hover behavior in here: https://terpimost.github.io/compose-decomposed/

image

result:
image

I'll do a bit more local testing and up a new PR for this if that's okay.

@zulipbot claim

from zulip.

zulipbot avatar zulipbot commented on July 18, 2024

Hello @PieterCK, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

from zulip.

PieterCK avatar PieterCK commented on July 18, 2024

oh whoops, never mind. Feel free to use my findings as a reference if anyone decides to take care of this issue, hope it helps. peace ๐Ÿ‘

from zulip.

zulipbot avatar zulipbot commented on July 18, 2024

Hello @PieterCK, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

from zulip.

nimishmedatwal avatar nimishmedatwal commented on July 18, 2024

@zulipbot claim

from zulip.

alya avatar alya commented on July 18, 2024

@PieterCK you're welcome to pick up an issue if you are waiting for review on the PR you're working on. From the contributor guide, the guideline is:

Iโ€™m waiting for the next round of review on my PR. Can I pick up another issue in the meantime? Someoneโ€™s first Zulip PR often requires quite a bit of iteration, so please make sure your pull request is reviewable and go through at least one round of feedback from others before picking up a second issue. After that, sure! If Zulipbot does not allow you to claim an issue, you can post a comment describing the status of your other work on the issue youโ€™re interested in, and asking for the issue to be assigned to you. Note that addressing feedback on in-progress PRs should always take priority over starting a new PR.

from zulip.

PieterCK avatar PieterCK commented on July 18, 2024

Thank you for informing me! I'll be more mindful of the contribution rules next time. ๐Ÿ˜ƒ ๐Ÿ‘

from zulip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.