learn-co-curriculum / react-simple-state-lab Goto Github PK

I was getting this spec error:

`1)
has an event listener that, when clicked, calls this.setState() once (make sure you aren't setting state directly, but instead using the component's 'setState' method):

  AssertionError: expected false to equal true
  + expected - actual

  -false
  +true
  
  at Context.<anonymous> (test/1-Cell.test.js:52:36)

`

but I have a setState() method on my Cell component:

It would appear that the sinon.spy is not working for this spec:

it("has an event listener that, when clicked, calls this.setState() once (make sure you aren't setting state directly, but instead using the component's 'setState' method)", () => { const setState = sinon.spy(Cell.prototype, 'setState'); cellWhite.find('div').simulate('click') expect(setState.calledOnce).to.equal(true); })

The resolution the technical helper and I came to was to comment out this spec.

Link to Canvas

Issue Subtype

• Master branch code
• Solution branch code
• Code tests
• Layout/rendering issue
• Instructions unclear
• Other (explain below)

Describe the Issue

Source

Concern

(Optional) Proposed Solution

Is it possible to show a solution for those learning this code for the first time, to adhere to just "state" and "props" and use code that follows the instructions given in the lab? Please?

What OS Are You Using?

• OS X
• Windows
• WSL
• Linux
• IllumiDesk

Any Additional Context?

Students are able to get the tests to pass but the app doesn't display in the browser.
I tried cloning the solution down to my system to test and that also did not work in the browser.

I don't have the bandwidth to look into it myself but if someone is able to check the recent PRs I know the lab has worked properly in the past, maybe they can locate the breaking change.

Link to Canvas

Issue Subtype

• Master branch code
• Solution branch code
• Code tests
• Layout/rendering issue
• Instructions unclear
• Other (explain below)

Describe the Issue

Source

Concern

(Optional) Proposed Solution

What OS Are You Using?

• OS X
• Windows
• WSL
• Linux
• IllumiDesk

Any Additional Context?

requires local version through forked copy for the lab server to start.

Click handlers need to be explained in the reading or a resource should be given (and its purpose explicitly stated).

Syntax for the genRow and genMatrix use one line arrow notation. Lab asks the user to insert a console.log into the code to help understand. This will throw an error, recommend replacing the () after => with {} so two lines of code will not throw an error.