1stthomas / ht7-html

I'm Thomas Plüss from Switzerland

Following some stats of my life at GitHub:

ht7-html's Issues

Make the attribute class also a node

Would the benefit really be greater than the investment?

In HTML attributes are nodes. But here, the iterator does not iterate over the attributes.

Where to transform the model data

Atm the transformation of the model data into the view is done by the view class. Should this not been done by the controller?

Avoid overhead by localized exception messages and own exceptions

#2 and #3 must be closed. Instead core exceptions must be used and the messages must be without any translation.

Basic widget classes

AbstractController, AbstractModel and AbstractView.

Figure must be capable to set the attributes of all its tags

New method to determine the several attributes.
If keys 'picture', 'figcaption' and/or 'figure' are set, empty or the found array. Otherwise the attributes array belongs to the figure.

PHP8 incompatibility

Todo:

• fix dependencies
• fix tests
• fix code

Interfaces with probably useless methods

• Ht7\Html\Widgets\Modelable - set/get data
• Ht7\Html\Node (abstract class) - set/get content

Avoid useless variable generations

Sometimes variables can be omitted by e.g. placing the options directly into the method call without loosing too much readability.

Implementation of the JSON serailization

Several classes need to implement the JsonSerializable interface. But the Text class needs to be handled by the NodeList.

Tests are not atomic as they might be

Where it is possible tests must integrate mocks and such.

[node] Replacer

HTML structure with placeholders, which will be replaced.

HTML string parsing

The Tag class need a method, to parse a HTML string and create a tree of Tag and Attribute instances. This should be implemented by using the DOMDocument and its anchestor classes.

[node] callback node implementation

Implementation of a callback node which must be able to run global functions and methods of classes and instances. This needs:

• Callback class extends \Ht7\Html\Node
• expand \Ht7\Html\Translators\ImporterHt7's createContentElement()
• expand tests

Rename function tests into integration tests

Wrong naming, let's fix it.

Exception messages through the translator

Atm most of the exception messages are not going through the translator class.

Package description

Chapters:

• abstract
• how to use it

Avoid inconsistent naming

\Ht7\Html\Widgets\AbstractView uses getItemList to provide the \Ht7\Html\Lists\NodeList. Let's change the method name into getNodeList.

[widget] table implementation

• Create a HTML table markup by row arrays.
• Architecture must be MVC.
• New system to define framework specific and non-specific attributes.

[tags] tag group implementation

For some tag groups it would be over engeneered to implement them with MVC architecture. They must be handled by a single class. These tag groups would be:

• audio
• figure
• picture
• select
• video

[widget] wrapper

A widget with a wrapper markup and items, which must be replaced on rendering.

Traits - unit testing improvments

Test traits according to https://phpunit.readthedocs.io/en/9.2/test-doubles.html#mocking-traits-and-abstract-classes.

Avoid static methods by refactoring ImporterHt7

Let's fix following issues:

• renaming translator -> transformer(?)
• no static methods in Ht7\Html\Translators\ImporterHt7

Registry to get the class names to use from

E.g. to register the \Ht7\Html\Tag class which the \Ht7\Html\Utilities\ImporterArray has to use.

No tests executed with github actions

Probably not the correct paths in the composer commands defined in composer.json.

Abstract Classes - unit testing improvments

Test abstract classes according to https://phpunit.readthedocs.io/en/9.2/test-doubles.html#mocking-traits-and-abstract-classes.

get-/setContent on the Node class

Changing this needs to change also the Text class. Instead of get-/setText() get-/setContent() must be used.

Use InvalidDatatypeException

Most of these datatype exceptions still use the \InvalidArgumentException.

AttributeList - method to merge AttributeLists

The AttributeList class needs to be expanded by a merge method. This method must merge the attributes of the AttributeList instances.

Missing tests for the importer classes

100% unit test coverage needed.

Optimizing import

Atm not only the importer does import, but also the Ht7\Html\Lists\NodeList class. Let's change this: Only the importers have to do imports, resp. creating the nodes etc.