2pai-dev / animoji Goto Github PK

As you may know, I assigned to #297 but when I started to work that out, I found (and realized) that Emoji is not a simple string like characters we know. It is Unicode.
So I proposed this issue be fixed first before fixing #297.

reference: https://thekevinscott.com/emojis-in-javascript/

Due on hacktoberfest , we handle so many PR
and we think that we need 1 new maintainer for this project

The candidate maintainer must be
at least have 2 PR , on improving the animoji (not adding animeList)

And the responsibility of maintainer is

1. Reviewing PR
2. Improving workflow

If you're interested & eligible to be maintainer for this project , please comment on this issue

there's anime who have more than 5 emojis

the goal is to edit the emojis, and make sure that emojis is < 5

we need README.md
reference:https://github.com/brittanyrw/emojiscreen/blob/master/README.md
and for CONTRIBUTING.md
reference : https://github.com/alfg/opendrinks/blob/master/CONTRIBUTING.md

comment to this issue if you want take this PR

Hello, it looks like there's an error in the code, I can't see any title when I click on the emoji card, here's the error on the console :
Uncaught TypeError: Cannot convert object to primitive value at RegExp.test (<anonymous>) at HTMLDivElement.<anonymous> (bootstrap.js:1434) at Function.each (jquery.js:381) at x.fn.init.each (jquery.js:203) at x.fn.init.t._jQueryInterface [as collapse] (bootstrap.js:1428) at HTMLDivElement.<anonymous> (bootstrap.js:1488) at Function.each (jquery.js:381) at x.fn.init.each (jquery.js:203) at HTMLDivElement.<anonymous> (bootstrap.js:1483) at HTMLDocument.dispatch (jquery.js:5429)

as you can see, there are some open pull requests. some of them are has conflict on it. we are openly looking for anyone who able to fix it.
please let us know if you want to take this by comment in this issue. thank you ✨✨✨

As you can see, there are a lot of file names with an inconsistent pattern. Should we standardize submitted file names under src/datasource/? Using kebab-case maybe?

Where should we make animoji?

the goal is make this button redirect to this github repository

we need testing for this app
the important thing is make sure that emojis <= 5
if you can work with this issue please comment

after creating new pull request, there will be a checking branch , it goes to error or uncomplite checking branch, but several minuet its changed to All checks have passed

Create Integration Test & CI Pipeline to make sure the length of emojis is less or equal than 8.
We can use Github actions as a CI pipeline
This issue aims to avoid this case :

the ui is not very good, and i think we need to improve the ui
if you have an idea and want to improve, PR to this issue