4source / vare-obsidian-plugin

This is a plugin for Obsidian (https://obsidian.md). Allows you to easily manage your plugins and themes inside Obsidian.

 

vare-obsidian-plugin's Issues

[Bug+FR]: Source repo for unlisted plugin does not change if removed and reinstalled from community plugins

Describe the bug

I recently forked the teleprompter plugin, and published my own release files for it. To add it into Obsidian I removed the original and added mine as an "unlisted" plugin. After getting my changes implemented on the upstream repo, I removed the unlisted plugin and reinstalled the official one.

However, VARE is still pulling releases from my repo despite reinstalling the plugin.

I recommend setting an option to change/update (and reset if applicable) the source repo in VARE's options

I also recommend showing a hint text that shows the currently selected source repository in addition to these:

How to Reproduce

Fork a plugin. Add the fork as an unlisted repo. Uninstall the plugin. Reinstall the official plugin.

Expected behavior

Update the source repo on reinstallation

OS of your device

Win10

Obsidian Version

v1.6.3

Plugin Version

0.1.1

Additional context

This is a dual bug report + feature request.

I'd like to be able to change the source repo as well.

[FEAT]: Fork links

Description of the unfavorable solution

At the moment only releases of the original repo are possible to download. But at many projects there are other contributors with limited permissions. They can't offer an Beta release for this plugin.

Describe the feature you would like to have

Add option to list additional releases.

Fork Releases

• Option for each plugin to add ONLY fork URLs to see releases from there.

Adds contributor/releases Versions to Version drop down.
With this contributors can release versions on there fork and if testers add there fork link there can install them as the 'original plugin'. Fetch possible Forks from GitHub for autocomplete.

Development path

• Option for each plugin to add Development Path on local Computer.

Adds an dev Version to the Version drop down checks for changes in this path and pulls the changes to plugin folder.

Check for git branches and create for each branch an dev/branch Version

Additional context

Fork from contributor with release 0.5.1

[FEAT]: Collab with Obsidian BRAT?

Description of the unfavorable solution

N/A

Describe the feature you would like to have

N/A

Additional context

It seems like these 2 plugins target similar functionality and are maintained at a similar frequency.

If that's the case, I'd like to suggest that you combine your efforts and move both into a gh org.

You are both MIT licensed, so it seems like you are both are on the same page about IP.

[Bug]: Wrong tag asset URL used in fetchManifest

Describe the bug

Currently, you use this to retrieve manifest.json:

vare-obsidian-plugin/src/util/GitHub.ts

Lines 104 to 120 in 307ba0e

	export async function fetchManifest(repository: string, tag_name?: string): Promise<PluginManifest | undefined> {
	const URL = `https://raw.githubusercontent.com/${repository}/${tag_name ? tag_name : 'HEAD'}/manifest.json`;
	try {
	if (!repositoryRegEx.test(repository)) {
	throw Error('Repository string do not match the pattern!');
	}
	// Do a request to the url
	const response = await request({ url: URL });
	// Process the response
	return (await JSON.parse(response)) as PluginManifest;
	}
	catch (e) {
	(e as Error).message = 'Failed to fetch the manifest for plugin! ' + (e as Error).message;
	console.error(e);
	}
	}

This is the wrong URL. Obsidian uses the Release REST API and not the raw file. This is an important distinction, because the release asset and the ref/raw asset, don't have to be the same.

• Releases REST API: https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#list-releases

How to Reproduce

Try to add anonhostpi/obsidian-exposed-api and install 0.0.3-f

It fails, because the wrong manifest file was used

Expected behavior

It should use the

OS of your device

Win11

Obsidian Version

v1.6.3

Plugin Version

0.3.5

Additional context

Going to be working on a PR in a moment to fix this for ya.