4txj7f / cvc5 Goto Github PK

Check why the portfolio build has issues. This might not be worth fixing right now if it is due to multiple copies of the SMTEngine coexisting.

It seems like initInternal is not really useful anymore (at least not for the pull request). Remove initInternal and the private variables from the preprocessing passes. Instead get the necessary variables at the beginning of applyInternal from the API.

We could make a distinction between plug-ins that only need limited access and can be easily implemented by users and having special plug-ins with additional capabilities.

Each instance of an SMTEngine should get its own copy of the PreprocessingPassRegistry.

For each variable in init, we need to decide about one of the following things:

• Move it to the API class (probably reserved for read only access)
• Move it to the assertion pipeline (probably for objects that are modified by multiple passes)
• Have them owned by a pass (the object gets created and destroyed with the pass)

Random comments on the poster (will add more to the issue as time goes by):

• Mention how many different preprocessing passes there are
• Maybe include two or so examples of preprocessing passes
• API -> Context
• Maybe have a list of classes that you implemented (PreprocessingPass, PreprocessingPassContext, PreprocessingPassRegistry) with a 1-2 sentence description of their purpose.
• Drawing is missing PreprocessingPassRegistry

Currently the PassResult is a struct but we should use an enum with CONFLICT and NO_CONFLICT.

Each preprocessing pass should get its own .h and .cpp file in the src/preproc directory.

For all PreprocessingPasses, make sure that accesses to the NodeManager happen through the thread_local variable, i.e. NodeManager::currentNM() and not through the SMT engine.

There should be an API class that all PreprocessingPasses have access to. Probably the easiest thing to do the following:

[ ] Create a PreprocessingPassAPI class that takes all variables that are currently passed into init
[ ] Create an instance of such a class at the beginning of ProcessAssertions
[ ] Remove all arguments from init() and instead have a single argument that is a pointer to the API
[ ] Change accesses to API variables to go through the API
[ ] Add methods to the API to avoid accesses to the variables in the API

We will have to move some variables out of the API but it seems like the easiest would be to get something working first.

Benchmarks:

https://clc-gitlab.cs.uiowa.edu:2443/SMT-LIB-benchmarks/QF_BV/tree/master/dwp_formulas

Likely to help: Different number of repeatSimp().