Not all the tests run on Linux

#18 · closed · 3 comments

wacumov

Test cases that do not run on Linux: - testMixedReadByte - testMixedReadBytes - testReadBytesThrowsBeforeReading - testReadBitsThrowsBeforeReading - testBool

Comments

Cosmo

Hi @wacumov! it looks like, i forgot to add those tests to the `allTests` array. Wouldn't this help to fix the issue? I took a look into your PR but was not sure what's going on Linux 😅 Thanks!

Hi @Cosmo! Yes, some test cases are missing on Linux. I've fixed it in the PR and have added `LinuxVerificationTests` to prevent such a situation in the future. [Here](https://github.com/wacumov/BinaryKit/runs/1248842855) you can see that 20 test cases run on Linux and 21 on Mac OS (20 from `allTests` + 1 from `LinuxVerificationTests`)

Cosmo

Oh, I see -- smart! :D Thanks a lot!