cosmo / binarykit Goto Github PK

I'm sure I'm doing something wrong, could you point me right direction please? Im trying to read signed value but not sure how to correctly read negative one.

I added category to accomplish this

extension Binary {
    
    mutating func readSignedBits(quantitiy: Int) throws -> Int {
        
        if try readBit() == 1 {
            let bit = try readBits(quantitiy: quantitiy - 1)

            let bitsReversed = String(String(bit, radix: 2).map({ $0 == "1" ? "0" : "1" }))
            return -Int(bitsReversed, radix: 2)! - 1
        } else {
            return try readBits(quantitiy: quantitiy - 1)
        }
        
    }
    
}

but it doesn't "feel" right

Test cases that do not run on Linux:

• testMixedReadByte
• testMixedReadBytes
• testReadBytesThrowsBeforeReading
• testReadBitsThrowsBeforeReading
• testBool

Hi Devran, could you help me to understand, is it intended writing behaviour that divides writing with bits and bytes?

For example:

var bin = Binary(bytes: [])
bin.writeBit(bit: 1)
bin.writeByte(8)

I would expect the binary is 0b1000_0100_0000_0000 - padded with zeros to the end of the byte.
The Actual result is 0b1000_0000_0000_1000 - written byte adde as next but bit cursor still points to the position '1'.

I'm getting wrong data while reading with using readBit() and readByte() methods, though readBitCursor increments correctly.

Test case:

1. The data is 0b1010_1101_1010_1111.
2. Do try bin.readBit() result 1
3. Do try bin.readByte()
   Actual result: 173
   Expected result: 91

The expected behaviour is that Binary reads sequentially:

//                                     readBitCursor              // 9
//                                          | 
var binary = Binary(bytes: [0b1_1011100, 0b1_0101111])
//                            | |___________| 
//                            |       | 
//                            | try binary.readBit()              // 91
//                            try binary.readBit()                // 1