friendsofshopware / froshsharebasket Goto Github PK
View Code? Open in Web Editor NEWThis plugin allows your customers to save the current basket and share it via link.
License: MIT License
This plugin allows your customers to save the current basket and share it via link.
License: MIT License
It could be maybe interesting for a Shop owner to know which products are how often in a saved basket.
Maybe a simple list of all saves with a grid which shows the saved products
Me likes nice urls.
sharebasket/load/bID/[id]
isn't nice.
Maybe a different controller loadbasket
for this, rsulting like loadbasket/bID/[id]
?
Beim Speichern von Custom Product Artikeln werden alle Daten korrekt gespeichert, die Endsumme im Warenkorb stimmt aber nicht, da wird nur der Grundbetrag das Custom Product Artikels genommen.
Die komplette Summe des Custom Products sollte inkl. der Konfiguration berücksichtigt werden.
PHP 7.2, SW 5.5.7
Hi, will there be a compatiblity with shopware versions older than 5.5 (5.4.6 for example) at some time?
After saving a basket, the button "E-Mail" opens a new E-Mail, but don't include the link to the saved basket.
I expected to see a new E-Mail open up with the link to the saved basket.
This only occurs in a shop using Business Essentials 3.2.2. Shopware 5.5.3 Build Rev 201810301443
Shop without Business Essentials - working like expected:
Shop with Business Essentials - E-Mail share not working:
--
♥ ANY INCOMPLETE REPORT WILL BE CLOSED RIGHT AWAY ♥
If a product with a custom product is placed in the shopping basket, the configuration of the custom product remains until the shopping basket (item with the custom product position) is deleted in the originally created browser.
The configuration of the custom product should not be deleted when the shopping cart is loaded and the item is deleted in the created browser.
--
♥ ANY INCOMPLETE REPORT WILL BE CLOSED RIGHT AWAY ♥
Our Frontend is reachable under https://www.example.com and our backend under https://backend.example.com/backend.
When opening 'Store additional fields' within the plugin config to retrieve the possible attributes the plugin tries to reach the following URL:
https://backend/AttributeData/list?raw=1&table=s_order_details_attributes&_dc=1586171977581&page=1&start=0&limit=25
This runs into an error as 'backend' is for sure not valid.
The store 'url' in Resources/config.xml is not working when using a subdomain which includes 'backend'
proxy: {
type: 'ajax',
url: '/backend/AttributeData/list?raw=1&table=s_order_details_attributes',
reader: {
type: 'json',
root: 'data',
totalProperty: 'total'
}
}
proxy: {
type: 'ajax',
url: window.location.protocol + '//' + window.location.hostname + '/backend/AttributeData/list?raw=1&table=s_order_details_attributes',
reader: {
type: 'json',
root: 'data',
totalProperty: 'total'
}
}
How can this fix be considered (eg. opening a pull request)?
Thanks,
Dirk
$attributes = unserialize($article->getAttributes());
Could be potential a security issue. Please fill the second parameter, to disallow instantiating of classes
7.3
5.6.1
Hi there,
when I try to update "Warenkorb teilen" and "Variantenwechsel im Warenkorb" I get this error:
Error
Sie besitzen keine gültige Lizenz um dieses Plugin zu verwenden.
Error code: BinariesException-15
"You have no valid license for this plugin"
Thanks in Advance
Best Regards
Gunnar
Updateing the plugins.
Click on Update button.
and deliver already existing id and update dates related to automatic deletion.
related #5
Just out of curiosity, is there a reason you prefer fetch mode PDO::FETCH_OBJ
instead of an array? Personally I prefer arrays in that regard.
Then, while not absolutely necessary, maybe consider using un/serialize instead of json_en/decode. While encoding json is a tad faster at larger data sizes, serialize is optimized for use in closed PHP applications. See this page for reference. Also I'd prefer an array as the result of decoding, obviously wouldn't even be a question when using serialize. :)
Massively requesting that endpoint could result in a flooded database. How about a session-based timeout or storing the unique basket code once inserted and updating the according record on subsequent requests?
Edit: Maybe consider using an ajax post request to save the basket. Shopware's CSRF protection can provide some security against automated spam.
There could be a message, when basket was loaded
FroshShareBasket/Subscriber/Checkout.php
Line 45 in 238c7bf
You seem to only require the router
service here. Why not just inject it directly instead of the service container? :)
FroshShareBasket/Subscriber/CronJob.php
Line 50 in 238c7bf
Same goes for this subscriber where you only require dbal_connection
and change removing relating this date 💭
Sorry for spamming :-)
We are using this plugin for our shopware Shop. It enables clients to rent articles for a certain time.
https://store.shopware.com/rhiem38738281933/mietartikel-artikel-vermieten.html
This time is not stored in the shared cart. I set all Fields in Backend to be stored, but these aren't stored.
Fields from external Plugin should be stored in Cart
Please provide information about the environment in which the issue occurs (e.g. PHP version, webserver, Shopware version, debugging information if you can provide).
Es wäre toll, wenn mann in der E-Mail nicht nur den Link sehen würde, sondern auch einen zusätzlichen Text.
Mir würde es reichen wenn ein Textbaustein vor dem Link und ein Textbaustein danach wäre.
7.4.30
5.5.10
When using the FroshShareBasket plugin with the "Set Article Plugin" the prices in the shopping cart are calculated incorrectly.
https://store.shopware.com/tonur31765851076/set-artikel.html
Both plugins work independently of each other.
We have to delete the server cache, to empty the price for the basket (also when its already empty)
Compatibility
Reproduce:
htacces
konorg|shopware
Product without Set Article Plugin, go to cart and click "Warenkorb teilen", copy link into new tab
https://www.konorg-shop.de/_testumgebung/roll-up-display-basic-513
Product with Set Article Plugin , go to cart and click "Warenkorb teilen", copy link into new tab, reload different prices will be shown
https://www.konorg-shop.de/_testumgebung/led-messestand-modulap-one-set-cleo-1454
7.4
5.7.7
In Ihrer Config "Zusätzliche Felder speichern", beziehen sie sich auf die Tabelle "s_order_detail_attributes".
Aber in Ihrer Funktion "getBasketAttributes" bauen sie einen SQL-Query, der sich auf die Tabelle "s_order_basket_attributes" bezieht. Was dazu führt, dass die folgende Abfrage bei Freitextfeldern von anderen Plugins nicht ausgeführt wird.
Pfad: custom/plugins/FroshShareBasket/Components/ShareBasketService.php Zeile: 116 - 119
if ($value && in_array($attribute, $attributesToStore, false)) { $basketArticle['attributes'][$attribute] = $value; }
Wenn sie in ihrer Config die Tabelle "s_order_detail_attributes" mit der Tabelle "s_order_basket_attributes" austauschen, können die entsprechenden Freitextfelder ausgewählt und die Abfrage ausgeführt werden.
Nachstellen können sie diesen Bug, mit jedem Freitextfeld welches nicht Standardmäßig von Shopware kommt.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.