aaroncql / pe

Loading...

pe's Issues

DG figure 5: the Model object seems to be wrongly destroyed

The Model object is not initialised anywhere in this sequence diagram, why would the Model object be destroyed within this sequence diagram?

DG figure 6: missing multiplicities

Multiple multiplicities seem to be missing.

For example, how many Status object can be contained within the Task object? How many Status objects does a Task know about? How many UniqueTaskList can be contained within the JelphaBot object?

Editing a task using the edit command will result in the Task List not working

Steps to reproduce:

1. Assume we are using the sample data
2. Execute list module
3. Notice that CS3230 is the first item listed:
   
4. Execute edit 1 m/cs3230 (notice the small caps in "cs")
5. Resulting list is shown:
   
6. Note that the CS3230 tasks completely disappears from the whole task list even when scrolled to the bottom

Confusing error message for reminder command

With a wrong usage of parameters like reminder 1 days/23 hours/1:

The use of "reminder date should be within one week from now" does not really explain how the days/ parameter should be used.

Help command figure is missing

The help command seems to have a figure label, but do not have any actual diagrams/figures:

DG figure 11: many missing details

Almost all the outgoing and incoming arrows does not have a message supplied. Since there are also no explanations in the DG to explain how this sequence diagram works, it is really difficult to understand what is going on.

DG figure 5: return data is not labelled correctly

An object of type DeleteCommand named c is created, but yet it returns d to the caller:

Or you might actually be returning something else which the name d is also not clear enough.

Command history not browsing properly

Steps to reproduce:

1. Enter at least 3 commands into the history
   • eg. enter find 1, find 2, then find 3
2. Press the Up arrow key twice: find 2 is shown correctly
3. Press the Down arrow key once
   • Expected: find 3 should be shown
   • What actually happens: command box still shows find 2

When changing browsing direction, the first down OR up arrow key will not change the history. Thus, a user can alternate pressing once between Up and Down arrow keys without ever changing the command currenly being shown.

Date can be unrealistically set for edit and add commands

Able to do: edit 1 dt/Jan-1-0000 23 23
Or: edit 1 dt/Jan-1-4000 23 23

Tasks should not be able to be set with such extreme dates.

DG sequence diagrams for Reminder feature missing/wrong details

Figure 26: what does LogicManager call ReminderCommand for? And what did ReminderCommand eventually return to LogicManager?

Figure 27: does ReminderCommand actually instantiate JelphaBot? Or is it calling some other method from an already instantiated JelphaBot?

Unhandled exception for reminder command in reminder tab

Steps to reproduce:

1. Enter reminder -21 days/0 hours/0 (or any index <= 0 for that matter)
2. Notice that no error was shown to the user that this is not a valid command

Java throws ArrayIndexOutOfBoundsException in the terminal:

Some text in productivity tab is clipped and cannot be seen

Text below 0 out of 4 done. is clipped and cannot be seen:

Module codes truncated and cannot be seen in calendar tab

Module codes truncates into ellipsis even when application is in full screen

Note the CS21...:

Date for calendar command can be unrealistically small

eg. calendar Jun-0000 should not be a valid command.

Such a date seems to be way too long ago to be useable.

DG figure 20: missing case

When checking the argument, what about the case where none of the argument matches?

Unhandled exception for start command in productivity tab

Steps to reproduce:

1. Enter start 0 (or any index <= 0 for that matter)
2. Notice that no error was shown to the user that this is not a valid command

Java throws ArrayIndexOutOfBoundsException in the terminal:

DG figure 9: unclear messages

Call for constructor is missing. Return message to the caller is also missing.

Unhandled exception for stop command in productivity tab

Steps to reproduce:

1. Enter stop 0 (or any index <= 0 for that matter)
2. Notice that no error was shown to the user that this is not a valid command

Java throws ArrayIndexOutOfBoundsException in the terminal: