aarondr77 / mortgage Goto Github PK

collectMoney seems like a mis-named event. Also - style says capitalize the first letter of the Event as well - else this looks like a function call.

Why is 1000 used here? It seems like you might be trying to turn things into Finney - but this would require a / rather than a *. Comments would be helpful - and declaring and constants as such, with helpful names!

Any/all good contract will have some tests to go along with it. This contract would go well with a Truffle directory (and some tests!).

This would help us catch any rounding issues (which I have yet to look for [and I'll refrain for now]) - as well as any other typos that might exist.

Looking forward to checking a comprehensive test suite out :)

I think this is meant to let them withdraw parts of the balance of the contract (or at least what the borrower has sent in). However, it does not do this.

This allows you to better refer to them in tests, watch for them using a web front end, etc.

90 * 1 Day == 90 Days. :)

Code has code (and maybe some comments). This looks like a great readme to me!

Unclear constants used throughout the contract. Hard to follow. Should define them as constant uints to help reader/auditer follow along (and to stop yourself from forgetting to update in multiple places!).

Closing other issue about this as this is a superset of that.

Here are some examples:

https://github.com/aarondr77/Mortgage/blob/master/Code#L71

https://github.com/aarondr77/Mortgage/blob/master/Code#L84